Patch "sctp: sctp gso should set feature with NETIF_F_SG when calling skb_segment" has been added to the 4.9-stable tree

This is a note to let you know that I've just added the patch titled

sctp: sctp gso should set feature with NETIF_F_SG when calling skb_segment

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sctp-sctp-gso-should-set-feature-with-netif_f_sg-when-calling-skb_segment.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Xin Long <[email protected]>
Date: Tue, 24 Jan 2017 14:05:16 +0800
Subject: sctp: sctp gso should set feature with NETIF_F_SG when calling skb_segment

From: Xin Long <[email protected]>

[ Upstream commit 5207f3996338e1db71363fe381c81aaf1e54e4e3 ]

Now sctp gso puts segments into skb's frag_list, then processes these segments in skb_segment. But skb_segment handles them only when gs is enabled, as it's in the same branch with skb's frags.

Although almost all the NICs support sg other than some old ones, but since commit 1e16aa3ddf86 ("net: gso: use feature flag argument in all protocol gso handlers"), features &= skb->dev->hw_enc_features, and xfrm_output_gso call skb_segment with features = 0, which means sctp gso would call skb_segment with sg = 0, and skb_segment would not work as expected.

This patch is to fix it by setting features param with NETIF_F_SG when calling skb_segment so that it can go the right branch to process the skb's frag_list.

---
 net/sctp/offload.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@@ -68,7 +68,7 @@ static struct sk_buff *sctp_gso_segment(
 		goto out;
 	}
 
-	segs = skb_segment(skb, features | NETIF_F_HW_CSUM);
+	segs = skb_segment(skb, features | NETIF_F_HW_CSUM | NETIF_F_SG);
 	if (IS_ERR(segs))
 		goto out;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/sctp-sctp-gso-should-set-feature-with-netif_f_sg-when-calling-skb_segment.patch queue-4.9/sctp-sctp_addr_id2transport-should-verify-the-addr-before-looking-up-assoc.patch