Skip to contentSkip to conversation

Patch "iio: adc: ti_am335x_adc: allocating too much in probe" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: adc: ti_am335x_adc: allocating too much in probe

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-adc-ti_am335x_adc-allocating-too-much-in-probe.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5ba5b437efaa7a502eec393c045d3bf90c92c4e9 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Wed, 10 May 2017 08:51:09 +0300
Subject: iio: adc: ti_am335x_adc: allocating too much in probe

From: Dan Carpenter <[email protected]>

commit 5ba5b437efaa7a502eec393c045d3bf90c92c4e9 upstream.

We should be allocating enough information for a tiadc_device struct which is about 400 bytes but instead we allocate enough for a second iio_dev struct which is over 2000 bytes.

Fixes fea89e2dfcea ("iio: adc: ti_am335x_adc: use variable names for sizeof() operator")
---
 drivers/iio/adc/ti_am335x_adc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ti_am335x_adc.c +1 -1
@@ -614,7 +614,7 @@ static int tiadc_probe(struct platform_d
 		return -EINVAL;
 	}
 
-	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*indio_dev));
+	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*adc_dev));
 	if (indio_dev == NULL) {
 		dev_err(&pdev->dev, "failed to allocate iio device\n");
 		return -ENOMEM;

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/drivers-misc-c2port-c2port-duramar2150.c-checking-for-null-instead-of-is_err.patch queue-4.11/iio-adc-ti_am335x_adc-allocating-too-much-in-probe.patch queue-4.11/staging-bcm2835-camera-fix-error-handling-in-init.patch queue-4.11/staging-rtl8188eu-prevent-an-underflow-in-rtw_check_beacon_data.patch