Patch "usb: gadget: udc: renesas_usb3: fix pm_runtime functions calling" has been added to the 4.11-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
usb: gadget: udc: renesas_usb3: fix pm_runtime functions calling
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-gadget-udc-renesas_usb3-fix-pm_runtime-functions-calling.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
cdc876877ebc3f0677b267756d4564e2a429e730Mon Sep 17 00:00:00 2001
From: Yoshihiro Shimoda <[email protected]>
Date: Wed, 26 Apr 2017 20:50:07 +0900
Subject: usb: gadget: udc: renesas_usb3: fix pm_runtime functions calling
From: Yoshihiro Shimoda <[email protected]>
commit cdc876877ebc3f0677b267756d4564e2a429e730 upstream.
This patch fixes an issue that this driver is possible to access the registers before pm_runtime_get_sync() if a gadget driver is installed first. After that, oops happens on R-Car Gen3 environment. To avoid it, this patch changes the pm_runtime call timing from probe/remove to udc_start/udc_stop.
--- drivers/usb/gadget/udc/renesas_usb3.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/usb/gadget/udc/renesas_usb3.c +6 -6
@@ -1707,6 +1707,9 @@ static int renesas_usb3_start(struct usb/* hook up the driver */ usb3->driver = driver; +pm_runtime_enable (usb3_to_dev (usb3)); +pm_runtime_get_sync (usb3_to_dev (usb3)); +renesas_usb3_init_controller (usb3);return 0 ;
@@ -1724,6 +1727,9 @@ static int renesas_usb3_stop(struct usb_renesas_usb3_stop_controller (usb3);spin_unlock_irqrestore (&usb3->lock, flags); +pm_runtime_put (usb3_to_dev (usb3)); +pm_runtime_disable (usb3_to_dev (usb3)); +return 0 ; }
@@ -1761,9 +1767,6 @@ static int renesas_usb3_remove(struct pl {struct renesas_usb3 *usb3 =platform_get_drvdata (pdev); -pm_runtime_put (&pdev->dev); -pm_runtime_disable (&pdev->dev); -usb_del_gadget_udc (&usb3->gadget);__renesas_usb3_ep_free_request (usb3->ep0_req);
@@ -1948,9 +1951,6 @@ static int renesas_usb3_probe(struct pla usb3->workaround_for_vbus = priv->workaround_for_vbus; -pm_runtime_enable (&pdev->dev); -pm_runtime_get_sync (&pdev->dev); -dev_info (&pdev->dev,"probed\n" );return 0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/usb-gadget-udc-renesas_usb3-fix-deadlock-by-spinlock.patch queue-4.11/phy-rcar-gen3-usb2-fix-implementation-for-runtime-pm.patch queue-4.11/usb-gadget-udc-renesas_usb3-fix-pm_runtime-functions-calling.patch queue-4.11/usb-gadget-udc-renesas_usb3-lock-for-pn_-registers-access.patch