drm/msm: fixes for 4.12
PATCH 1/1 drm/msm: fixes for 4.12
Hey Rob, here is a late breaking overflow fix suitable for sending up to Linus for 4.12 if you are so inclined.
Kasin Li (1):
drm/msm: Fix potential buffer overflow issue
drivers/gpu/drm/msm/msm_gem_submit.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
1.9.1
PATCH 1/1 drm/msm: Fix potential buffer overflow issue
From: Kasin Li <[email protected]>
In function submit_create, if nr_cmds or nr_bos is assigned with negative value, the allocated buffer may be small than intended. Using this buffer will lead to buffer overflow issue.
Signed-off-by Kasin Li <[email protected]>
Signed-off-by Jordan Crouse <[email protected]>
--- drivers/gpu/drm/msm/msm_gem_submit.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/msm/msm_gem_submit.c +6 -3
@@ -31,11 +31,14 @@#define BO_PINNED 0x2000static struct msm_gem_submit *submit_create (struct drm_device *dev, -struct msm_gpu *gpu,int nr_bos,int nr_cmds) +struct msm_gpu *gpu,uint32_t nr_bos,uint32_t nr_cmds) {struct msm_gem_submit *submit; -int sz =sizeof (*submit) + (nr_bos *sizeof (submit->bos[0 ])) + - (nr_cmds *sizeof (*submit->cmd)); +uint64_t sz =sizeof (*submit) + (nr_bos *sizeof (submit->bos[0 ])) + + (nr_cmds *sizeof (submit->cmd[0 ])); + +if (sz >SIZE_MAX ) +return NULL ; submit =kmalloc (sz,GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);if (!submit)
Signature · 1 line
1.9.1