Patch "lib/cmdline.c: fix get_options() overflow while parsing ranges" has been added to the 4.11-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
lib/cmdline.c: fix get_options() overflow while parsing ranges
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
lib-cmdline.c-fix-get_options-overflow-while-parsing-ranges.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
a91e0f680bcd9e10c253ae8b62462a38bd48f09fMon Sep 17 00:00:00 2001
From: Ilya Matveychikov <[email protected]>
Date: Fri, 23 Jun 2017 15:08:49 -0700
Subject: lib/cmdline.c: fix get_options() overflow while parsing ranges
From: Ilya Matveychikov <[email protected]>
commit a91e0f680bcd9e10c253ae8b62462a38bd48f09f upstream.
When using get_options() it's possible to specify a range of numbers, like 1-100500. The problem is that it doesn't track array size while calling internally to get_range() which iterates over the range and fills the memory with numbers.
--- lib/cmdline.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/cmdline.c +3 -3
@@ -22,14 +22,14 @@* the values[M, M+1, ..., N] into the ints array in get_options. */ -static int get_range (char **str,int *pint) +static int get_range (char **str,int *pint,int n) {int x, inc_counter, upper_range; (*str)++; upper_range =simple_strtol ((*str),NULL ,0 ); inc_counter = upper_range - *pint; -for (x = *pint; x < upper_range; x++) +for (x = *pint; n && x < upper_range; x++, n--) *pint++ = x;return inc_counter; }
@@ -96,7 +96,7 @@ char *get_options(const char *str, int nbreak ;if (res ==3 ) {int range_nums; - range_nums =get_range ((char **)&str, ints + i); + range_nums =get_range ((char **)&str, ints + i, nints - i);if (range_nums <0 )break ;/*
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/lib-cmdline.c-fix-get_options-overflow-while-parsing-ranges.patch