Add support for write life time hints
Subsystems (7)
Jens Axboe
maintainerPATCH v10 1/1 Add support for write life time hints
A new iteration of this patchset, previously known as write streams. As before, this patchset aims at enabling applications split up writes into separate streams, based on the perceived life time of the data written. This is useful for a variety of reasons:
- For NVMe, this feature is ratified and released with the NVMe 1.3 spec. Devices implementing Directives can expose multiple streams. Separating data written into streams based on life time can drastically reduce the write amplification. This helps device endurance, and increases performance. Testing just performed internally at Facebook with these patches showed up to a 25% reduction in NAND writes in a RocksDB setup.
- Software caching solutions can make more intelligent decisions on how and where to place data.
Contrary to previous patches, we're not exposing numeric stream values anymore. I've previously advocated for just doing a set of hints that makes sense instead. See the coverage from the LSFMM summit this year:
https://lwn.net/Articles/717755/
This patchset attempts to do that. We add an fcntl(2) interface to get/set these types of hints. We define 4 hints that pertain to data write life times:
RWH_WRITE_LIFE_SHORT Data written with this flag is expected to have
a high overwrite rate, or life time.
RWH_WRITE_LIFE_MEDIUM Longer life time than SHORT
RWH_WRITE_LIFE_LONG Longer life time than MEDIUM
RWH_WRITE_LIFE_EXTREME Longer life time than LONG
The idea is that these are relative values, so an application can use them as they see fit. The underlying device can then place data appropriately, or be free to ignore the hint. It's just a hint.
A branch based on current master can be pulled
from here:
git://git.kernel.dk/linux-block write-stream.10
Changes since v9:
- Address Christoph's concerns:
- Add NVMe 'streams' parameter, default to off.
- Add file get/set fcntl() commands.
- Add helper for getting block opf mask from inode write hint.
- Fixup a few < 80 lines.
Changes since v8:
- Add file write hints as well. File hints override inode hints, if both are valid and available.
- Distinguish between "hint not set" or "hint none".
- NVMe: remove global stream allocation and stream parameter
- Rebase on top of new for-4.13/block, to fixup conflicts with the NOWAIT patchset.
Changes since v7:
- NVMe: change 'streams' parameter to be a bool enable/disable. We hardwire the number of streams anyway and use the appropriate amount, so no point in exposing this value.
- NVMe: collapse stream values appropriately, instead of just doing a basic MOD.
- Get rid of pwritev2(2) flags. Just use the fcntl(2) interface.
- Collapse some patches
- Change fcntl(2) interface to get/set values from a user supplied 64-bit pointer.
- Move inode-to-iocb mask setting to iocb_flags().
Changes since v6:
- Rewrite NVMe write stream assignment
- Change NVMe stream assignment to be per-controller, not per-ns. Then we can use the same IDs across name spaces, and we don't have to do lazy setup of streams.
- If streams are enabled on nvme, set io min/opt and discard granularity based on the stream params reported.
- Fixup F_SET_RW_HINT definition, it was 20, should have been 12.
Changes since v5:
- Change enum write_hint to enum rw_hint.
- Change fcntl() interface to be read/write generic
- Bring enum rw_hint all the way to bio/request
- Change references to streams in changelogs and debugfs interface
- Rebase to master to resolve blkdev.h conflict
- Reshuffle patches so the WRITE_LIFE_* hints and type come first. Allowed me to merge two block patches as well.
Changes since v4:
- Add enum write_hint and the WRITE_HINT_* values. This is what we use internally (until transformed to req/bio flags), and what is exposed to user space with the fcntl() interface. Maps directly to the RWF_WRITE_LIFE_* values.
- Add fcntl() interface for getting/setting hint values.
- Get rid of inode ->i_write_hint, encode the 3 bits of hint info in the inode flags intead.
- Allow a write with no hint to clear the old hint. Previously we only changed the hint if a new valid hint was given, not if no hint was passed in.
- Shrink flag space grabbed from 4 to 3 bits for RWF_* and the inode flags.
Changes since v3:
- Change any naming of stream ID to write hint.
- Various little API changes, suggested by Christoph
- Cleanup the NVMe bits, dump the debug info.
- Change NVMe to lazily allocate the streams.
- Various NVMe error handling improvements and command checking.
Changes since v2:
- Get rid of bio->bi_stream and replace with four request/bio flags. These map directly to the RWF_WRITE_* flags that the user passes in.
- Cleanup the NVMe stream setting.
- Drivers now responsible for updating the queue stream write counter, as they determine what stream to map a given flag to.
Changes since v1:
- Guard queue stream stats to ensure we don't mess up memory, if bio_stream() ever were to return a larger value than we support.
- NVMe: ensure we set the stream modulo the name space defined count.
- Cleanup the RWF_ and IOCB_ flags. Set aside 4 bits, and just store the stream value in there. This makes the passing of stream ID from RWF_ space to IOCB_ (and IOCB_ to bio) more efficient, and cleans it up in general.
- Kill the block internal definitions of the stream type, we don't need them anymore. See above.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerPATCH 1/9 fs: add fcntl() interface for setting/getting write life time hints
Define a set of write life time hints:
RWH_WRITE_LIFE_NOT_SET No hint information setRWH_WRITE_LIFE_NONE No hints about write life timeRWH_WRITE_LIFE_SHORT Data written has a short life timeRWH_WRITE_LIFE_MEDIUM Data written has a medium life timeRWH_WRITE_LIFE_LONG Data written has a long life timeRWH_WRITE_LIFE_EXTREME Data written has an extremely long life time
The intent is for these values to be relative to each other, no absolute meaning should be attached to these flag names.
Add an fcntl interface for querying these flags, and also for setting them as well:
F_GET_RW_HINT Returns the read/write hint set on the
underlying inode.
F_SET_RW_HINT Set one of the above write hints on the
underlying inode.
F_GET_FILE_RW_HINT Returns the read/write hint set on the
file descriptor.
F_SET_FILE_RW_HINT Set one of the above write hints on the
file descriptor.
The user passes in a 64-bit pointer to get/set these values, and the interface returns 0/-1 on success/error.
Sample program testing/implementing basic setting/getting of write hints is below.
Add support for storing the write life time hint in the inode flags and in struct file as well, and pass them to the kiocb flags. If both a file and its corresponding inode has a write hint, then we use the one in the file, if available. The file hint can be used for sync/direct IO, for buffered writeback only the inode hint is available.
This is in preparation for utilizing these hints in the block layer, to guide on-media data placement.
/*
* writehint.c: get or set an inode write hint
*/
#include <stdio.h>
#include <fcntl.h>
#include <stdlib.h>
#include <unistd.h>
#include <stdbool.h>
#include <inttypes.h>
#ifndef F_GET_RW_HINT
#define F_LINUX_SPECIFIC_BASE 1024
#define F_GET_RW_HINT (F_LINUX_SPECIFIC_BASE + 11)
#define F_SET_RW_HINT (F_LINUX_SPECIFIC_BASE + 12)
#endif
static char *str[] = { "RWF_WRITE_LIFE_NOT_SET", "RWH_WRITE_LIFE_NONE",
"RWH_WRITE_LIFE_SHORT", "RWH_WRITE_LIFE_MEDIUM", "RWH_WRITE_LIFE_LONG", "RWH_WRITE_LIFE_EXTREME" };
int main(int argc, char *argv[])
{
uint64_t hint;
int fd, ret;
if (argc < 2) {
fprintf(stderr, "%s: file <hint>\n", argv[0]);
return 1;
}
fd = open(argv[1], O_RDONLY);
if (fd < 0) {
perror("open");
return 2;
}
if (argc > 2) {
hint = atoi(argv[2]);
ret = fcntl(fd, F_SET_RW_HINT, &hint);
if (ret < 0) {
perror("fcntl: F_SET_RW_HINT");
return 4;
}
}
ret = fcntl(fd, F_GET_RW_HINT, &hint);
if (ret < 0) {
perror("fcntl: F_GET_RW_HINT");
return 3;
}
printf("%s: hint %s\n", argv[1], str[hint]);
close(fd);
return 0;
}--- fs/fcntl.c | 66 +++++++++++++++++++++++++++++++++++++++++ fs/inode.c | 11 +++++++ fs/open.c | 1 + include/linux/fs.h | 74 ++++++++++++++++++++++++++++++++++++++++++++-- include/uapi/linux/fcntl.h | 21 +++++++++++++ 5 files changed, 171 insertions(+), 2 deletions(-)
fs/fcntl.c +66 -0
@@ -243,6 +243,66 @@ static int f_getowner_uids(struct file *filp, unsigned long arg) }#endif +static long fcntl_rw_hint (struct file *file,unsigned int cmd, +unsigned long arg) +{ +struct inode *inode =file_inode (file); +bool on_file = false; +enum rw_hint hint; +long ret =0 ; + +switch (cmd) { +case F_GET_FILE_RW_HINT : + on_file = true; +case F_GET_RW_HINT : +/* +* If we ask for the file descriptor hint and it isn't set, +* return the underlying inode write hint. This is what +* writeback does as well. +*/ + hint =RWF_WRITE_LIFE_NOT_SET ; +if (on_file) + hint = file->f_write_hint; + +if (!on_file || hint ==RWF_WRITE_LIFE_NOT_SET ) + hint =mask_to_write_hint (inode->i_flags, +S_WRITE_LIFE_SHIFT ); +if (put_user (hint, (u64 __user *) arg)) + ret = -EFAULT ; +break ; +case F_SET_FILE_RW_HINT : + on_file = true; +case F_SET_RW_HINT : +if (get_user (hint, (u64 __user *) arg)) { + ret = -EFAULT ; +break ; + } +switch (hint) { +case RWF_WRITE_LIFE_NOT_SET : +case RWH_WRITE_LIFE_NONE : +case RWH_WRITE_LIFE_SHORT : +case RWH_WRITE_LIFE_MEDIUM : +case RWH_WRITE_LIFE_LONG : +case RWH_WRITE_LIFE_EXTREME : +if (on_file) { +spin_lock (&file->f_lock); + file->f_write_hint = hint; +spin_unlock (&file->f_lock); + }else +inode_set_write_hint (inode, hint); +break ; +default : + ret = -EINVAL ; + } +break ; +default : + ret = -EINVAL ; +break ; + } + +return ret; +} +static long do_fcntl (int fd,unsigned int cmd,unsigned long arg,struct file *filp) {
@@ -337,6 +397,12 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,case F_GET_SEALS : err =shmem_fcntl (filp, cmd, arg);break ; +case F_GET_RW_HINT : +case F_SET_RW_HINT : +case F_GET_FILE_RW_HINT : +case F_SET_FILE_RW_HINT : + err =fcntl_rw_hint (filp, cmd, arg); +break ;default :break ; }
fs/inode.c +11 -0
@@ -2120,3 +2120,14 @@ struct timespec current_time(struct inode *inode)return timespec_trunc (now, inode->i_sb->s_time_gran); }EXPORT_SYMBOL (current_time); + +void inode_set_write_hint (struct inode *inode,enum rw_hint hint) +{ +unsigned int flags =write_hint_to_mask (hint,S_WRITE_LIFE_SHIFT ); + +if (flags !=mask_to_write_hint (inode->i_flags,S_WRITE_LIFE_SHIFT )) { +inode_lock (inode); +inode_set_flags (inode, flags,S_WRITE_LIFE_MASK ); +inode_unlock (inode); + } +}
fs/open.c +1 -0
@@ -759,6 +759,7 @@ static int do_dentry_open(struct file *f, likely(f->f_op->write || f->f_op->write_iter)) f->f_mode |= FMODE_CAN_WRITE; + f->f_write_hint =WRITE_LIFE_NOT_SET ; f->f_flags &= ~(O_CREAT |O_EXCL |O_NOCTTY |O_TRUNC );file_ra_state_init (&f->f_ra, f->f_mapping->host->i_mapping);
include/linux/fs.h +72 -2
128 lines not on this page · raw message
include/uapi/linux/fcntl.h +21 -0
@@ -43,6 +43,27 @@/* (1U << 31) is reserved for signed error codes */ /* +* Set/Get write life time hints. {GET,SET}_RW_HINT operate on the +* underlying inode, while {GET,SET}_FILE_RW_HINT operate only on +* the specific file. +*/ +#define F_GET_RW_HINT (F_LINUX_SPECIFIC_BASE + 11) +#define F_SET_RW_HINT (F_LINUX_SPECIFIC_BASE + 12) +#define F_GET_FILE_RW_HINT (F_LINUX_SPECIFIC_BASE + 13) +#define F_SET_FILE_RW_HINT (F_LINUX_SPECIFIC_BASE + 14) + +/* +* Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be +* used to clear any hints previously set. +*/ +#define RWF_WRITE_LIFE_NOT_SET 0 +#define RWH_WRITE_LIFE_NONE 1 +#define RWH_WRITE_LIFE_SHORT 2 +#define RWH_WRITE_LIFE_MEDIUM 3 +#define RWH_WRITE_LIFE_LONG 4 +#define RWH_WRITE_LIFE_EXTREME 5 + +/* * Types of directory notifications that may be requested. */ #define DN_ACCESS 0x00000001/* File accessed */
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 2/9 block: add support for write hints in a bio
In reply to Jens AxboeNo functional changes in this patch, we just set aside 3 bits in the bio/request flags, which can be used to hold a WRITE_LIFE_* life time hint.
Ensure that we don't merge requests that have different life time hints assigned to them.
--- block/blk-merge.c | 16 ++++++++++++++++ fs/inode.c | 9 +++++++++ include/linux/blk_types.h | 31 +++++++++++++++++++++++++++++++ include/linux/fs.h | 2 ++ 4 files changed, 58 insertions(+)
block/blk-merge.c +16 -0
@@ -673,6 +673,14 @@ static struct request *attempt_merge(struct request_queue *q,return NULL ;/* +* Don't allow merge of different write hints, or for a hint with +* non-hint IO. +*/ +if ((req->cmd_flags &REQ_WRITE_LIFE_MASK ) != + (next->cmd_flags &REQ_WRITE_LIFE_MASK )) +return NULL ; + +/* * If we are allowed to merge, then append bio list * from next to rq and release next. merge_requests_fn * will have updated segment counts, update sector
@@ -791,6 +799,14 @@ bool blk_rq_merge_ok(struct request *rq, struct bio *bio) !blk_write_same_mergeable(rq->bio, bio))return false; +/* +* Don't allow merge of different write hints, or for a hint with +* non-hint IO. +*/ +if ((rq->cmd_flags &REQ_WRITE_LIFE_MASK ) != + (bio->bi_opf &REQ_WRITE_LIFE_MASK )) +return false; +return true; }
fs/inode.c +9 -0
@@ -2131,3 +2131,12 @@ void inode_set_write_hint(struct inode *inode, enum rw_hint hint)inode_unlock (inode); } } + +/* +* Returns block write hint mask for the inode +*/ +unsigned int inode_hint_to_opf (struct inode *inode) +{ +return write_hint_to_opf (inode_write_hint (inode)); +} +EXPORT_SYMBOL (inode_hint_to_opf);
include/linux/blk_types.h +31 -0
@@ -7,6 +7,7 @@#include <linux/types.h> #include <linux/bvec.h> +#include <linux/fs.h> struct bio_set ;struct bio ;
@@ -223,6 +224,10 @@ enum req_flag_bits { __REQ_RAHEAD,/* read ahead, can fail anytime */ __REQ_BACKGROUND,/* background IO */ + __REQ_WRITE_HINT_SHIFT,/* 3 bits for life time hint */ + __REQ_WRITE_HINT_PAD1, + __REQ_WRITE_HINT_PAD2, +/* command specific flags for REQ_OP_WRITE_ZEROES: */ __REQ_NOUNMAP, /* do not free blocks when zeroing */
@@ -244,6 +249,13 @@ enum req_flag_bits {#define REQ_RAHEAD (1ULL << __REQ_RAHEAD)#define REQ_BACKGROUND (1ULL << __REQ_BACKGROUND) +#define REQ_WRITE_SHORT (WRITE_LIFE_SHORT << __REQ_WRITE_HINT_SHIFT) +#define REQ_WRITE_MEDIUM (WRITE_LIFE_MEDIUM << __REQ_WRITE_HINT_SHIFT) +#define REQ_WRITE_LONG (WRITE_LIFE_LONG << __REQ_WRITE_HINT_SHIFT) +#define REQ_WRITE_EXTREME (WRITE_LIFE_EXTREME << __REQ_WRITE_HINT_SHIFT) + +#define REQ_WRITE_LIFE_MASK (0x7 << __REQ_WRITE_HINT_SHIFT) +#define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP)#define REQ_NOWAIT (1ULL << __REQ_NOWAIT)
@@ -335,4 +347,23 @@ struct blk_rq_stat { u64 batch; }; +static inline unsigned int write_hint_to_opf (enum rw_hint hint) +{ +return hint << __REQ_WRITE_HINT_SHIFT; +} + +/* +* Don't let drivers see WRITE_LIFE_NOT_SET, return NONE for that +*/ +static inline enum rw_hint opf_to_write_hint (unsigned int opf) +{ +enum rw_hint ret; + + ret = (opf &REQ_WRITE_LIFE_MASK ) >> __REQ_WRITE_HINT_SHIFT; +if (ret ==WRITE_LIFE_NOT_SET ) + ret =WRITE_LIFE_NONE ; + +return ret; +} +#endif /* __LINUX_BLK_TYPES_H */
include/linux/fs.h +2 -0
@@ -1912,6 +1912,8 @@ static inline bool HAS_UNMAPPED_ID(struct inode *inode)return !uid_valid (inode->i_uid) || !gid_valid (inode->i_gid); } +extern unsigned int inode_hint_to_opf (struct inode *inode); +static inline unsigned int write_hint_to_mask (enum rw_hint hint,unsigned int shift) {
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 3/9 blk-mq: expose write hints through debugfs
In reply to Jens AxboeUseful to verify that things are working the way they should. Reading the file will return number of kb written with each write hint. Writing the file will reset the statistics. No care is taken to ensure that we don't race on updates.
Drivers will write to q->write_hints[] if they handle a given write hint.
--- block/blk-mq-debugfs.c | 24 ++++++++++++++++++++++++ include/linux/blkdev.h | 3 +++ 2 files changed, 27 insertions(+)
block/blk-mq-debugfs.c +24 -0
@@ -135,6 +135,29 @@ static void print_stat(struct seq_file *m, struct blk_rq_stat *stat) } } +static int queue_write_hint_show (void *data,struct seq_file *m) +{ +struct request_queue *q = data; +int i; + +for (i =0 ; i <BLK_MAX_WRITE_HINTS ; i++) +seq_printf (m,"hint%d: %llu\n" , i, q->write_hints[i]); + +return 0 ; +} + +static ssize_t queue_write_hint_store (void *data,const char __user *buf, +size_t count,loff_t *ppos) +{ +struct request_queue *q = data; +int i; + +for (i =0 ; i <BLK_MAX_WRITE_HINTS ; i++) + q->write_hints[i] =0 ; + +return count; +} +static int queue_poll_stat_show (void *data,struct seq_file *m) {struct request_queue *q = data;
@@ -730,6 +753,7 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_queue_attrs[] = { {"poll_stat", 0400, queue_poll_stat_show}, {"requeue_list", 0400, .seq_ops = &queue_requeue_list_seq_ops}, {"state", 0600, queue_state_show, queue_state_write}, + {"write_hints", 0600, queue_write_hint_show, queue_write_hint_store}, {}, };
include/linux/blkdev.h +3 -0
@@ -594,6 +594,9 @@ struct request_queue {void *rq_alloc_data;struct work_struct release_work; + +#define BLK_MAX_WRITE_HINTS 5 +u64 write_hints[BLK_MAX_WRITE_HINTS ]; };#define QUEUE_FLAG_QUEUED 1/* uses generic tag queueing */
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 4/9 fs: add O_DIRECT support for sending down write life time hints
In reply to Jens Axboe--- fs/block_dev.c | 2 ++ fs/direct-io.c | 2 ++ fs/iomap.c | 5 ++++- 3 files changed, 8 insertions(+), 1 deletion(-)
fs/block_dev.c +2 -0
@@ -183,6 +183,8 @@ static unsigned int dio_bio_write_op(struct kiocb *iocb)/* avoid the need for a I/O completion work item */ if (iocb->ki_flags &IOCB_DSYNC ) op |=REQ_FUA ; + + op |=write_hint_to_opf (iocb_write_hint (iocb));return op; }
fs/direct-io.c +2 -0
@@ -385,6 +385,8 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio,else bio->bi_end_io = dio_bio_end_io; + bio->bi_opf |=write_hint_to_opf (iocb_write_hint (dio->iocb)); + sdio->bio = bio; sdio->logical_offset_in_bio = sdio->cur_page_fs_offset; }
fs/iomap.c +4 -1
@@ -803,7 +803,10 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, }if (dio->flags &IOMAP_DIO_WRITE ) { -bio_set_op_attrs (bio,REQ_OP_WRITE ,REQ_SYNC |REQ_IDLE ); +bio_set_op_attrs (bio,REQ_OP_WRITE , +REQ_SYNC |REQ_IDLE ); + bio->bi_opf |= +write_hint_to_opf (iocb_write_hint (dio->iocb));task_io_account_write (bio->bi_iter.bi_size); }else {bio_set_op_attrs (bio,REQ_OP_READ ,0 );
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 5/9 fs: add support for buffered writeback to pass down write hints
In reply to Jens Axboe--- fs/buffer.c | 14 +++++++++----- fs/mpage.c | 1 + 2 files changed, 10 insertions(+), 5 deletions(-)
fs/buffer.c +9 -5
@@ -49,7 +49,7 @@static int fsync_buffers_list (spinlock_t *lock,struct list_head *list);static int submit_bh_wbc (int op,int op_flags,struct buffer_head *bh, -struct writeback_control *wbc); +unsigned int hint,struct writeback_control *wbc);#define BH_ENTRY (list) list_entry((list), struct buffer_head, b_assoc_buffers)
@@ -1829,7 +1829,8 @@ int __block_write_full_page(struct inode *inode, struct page *page, do { struct buffer_head *next = bh->b_this_page; if (buffer_async_write(bh)) { - submit_bh_wbc(REQ_OP_WRITE, write_flags, bh, wbc); + submit_bh_wbc(REQ_OP_WRITE, write_flags, bh, + inode_write_hint(inode), wbc); nr_underway++; } bh = next;
@@ -1883,7 +1884,8 @@ int __block_write_full_page(struct inode *inode, struct page *page,struct buffer_head *next = bh->b_this_page;if (buffer_async_write (bh)) {clear_buffer_dirty (bh); -submit_bh_wbc (REQ_OP_WRITE , write_flags, bh, wbc); +submit_bh_wbc (REQ_OP_WRITE , write_flags, bh, +inode_write_hint (inode), wbc); nr_underway++; } bh = next;
@@ -3091,7 +3093,7 @@ void guard_bio_eod(int op, struct bio *bio) }static int submit_bh_wbc (int op,int op_flags,struct buffer_head *bh, -struct writeback_control *wbc) +unsigned int write_hint,struct writeback_control *wbc) {struct bio *bio;
@@ -3134,6 +3136,8 @@ static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, op_flags |=REQ_META ;if (buffer_prio (bh)) op_flags |=REQ_PRIO ; + + op_flags |=write_hint_to_opf (write_hint);bio_set_op_attrs (bio, op, op_flags);submit_bio (bio);
@@ -3142,7 +3146,7 @@ static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,int submit_bh (int op,int op_flags,struct buffer_head *bh) { -return submit_bh_wbc (op, op_flags, bh,NULL ); +return submit_bh_wbc (op, op_flags, bh,0 ,NULL ); }EXPORT_SYMBOL (submit_bh);
fs/mpage.c +1 -0
@@ -615,6 +615,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, goto confused;wbc_init_bio (wbc, bio); + bio->bi_opf |=inode_hint_to_opf (inode); }/*
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 6/9 ext4: add support for passing in write hints for buffered writes
In reply to Jens Axboe--- fs/ext4/page-io.c | 2 ++ 1 file changed, 2 insertions(+)
fs/ext4/page-io.c +2 -0
@@ -350,6 +350,7 @@ void ext4_io_submit(struct ext4_io_submit *io)if (bio) {int io_op_flags = io->io_wbc->sync_mode ==WB_SYNC_ALL ?REQ_SYNC :0 ; + io_op_flags |=inode_hint_to_opf (io->io_end->inode);bio_set_op_attrs (io->io_bio,REQ_OP_WRITE , io_op_flags);submit_bio (io->io_bio); }
@@ -397,6 +398,7 @@ static int io_submit_add_bh(struct ext4_io_submit *io, ret =io_submit_init_bio (io, bh);if (ret)return ret; + io->io_bio->bi_opf |=inode_hint_to_opf (inode); } ret =bio_add_page (io->io_bio, page, bh->b_size,bh_offset (bh));if (ret != bh->b_size)
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 7/9 xfs: add support for passing in write hints for buffered writes
In reply to Jens Axboe--- fs/xfs/xfs_aops.c | 2 ++ 1 file changed, 2 insertions(+)
fs/xfs/xfs_aops.c +2 -0
@@ -506,6 +506,7 @@ xfs_submit_ioend(return status; } + ioend->io_bio->bi_opf |=inode_hint_to_opf (ioend->io_inode);submit_bio (ioend->io_bio);return 0 ; }
@@ -565,6 +566,7 @@ xfs_chain_bio(bio_chain (ioend->io_bio, new);bio_get (ioend->io_bio);/* for xfs_destroy_ioend */ ioend->io_bio->bi_opf =REQ_OP_WRITE |wbc_to_write_flags (wbc); + ioend->io_bio->bi_opf |=inode_hint_to_opf (ioend->io_inode);submit_bio (ioend->io_bio); ioend->io_bio = new; }
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 8/9 btrfs: add support for passing in write hints for buffered writes
In reply to Jens Axboe--- fs/btrfs/extent_io.c | 1 + 1 file changed, 1 insertion(+)
fs/btrfs/extent_io.c +1 -0
@@ -2830,6 +2830,7 @@ static int submit_extent_page(int op, int op_flags, struct extent_io_tree *tree,bio_add_page (bio, page, page_size, offset); bio->bi_end_io = end_io_func; bio->bi_private = tree; + op_flags |=inode_hint_to_opf (page->mapping->host);bio_set_op_attrs (bio, op, op_flags);if (wbc) {wbc_init_bio (wbc, bio);
Signature · 1 line
2.7.4
Jens Axboe
maintainerPATCH 9/9 nvme: add support for streams and directives
In reply to Jens AxboeThis adds support for Directives in NVMe, particular for the Streams directive. Support for Directives is a new feature in NVMe 1.3. It allows a user to pass in information about where to store the data, so that it the device can do so most effiently. If an application is managing and writing data with different life times, mixing differently retentioned data onto the same locations on flash can cause write amplification to grow. This, in turn, will reduce performance and life time of the device.
--- drivers/nvme/host/core.c | 148 +++++++++++++++++++++++++++++++++++++++++++++-- drivers/nvme/host/nvme.h | 4 ++ include/linux/nvme.h | 48 +++++++++++++++ 3 files changed, 196 insertions(+), 4 deletions(-)
drivers/nvme/host/core.c +144 -4
@@ -65,6 +65,10 @@ static bool force_apst;module_param (force_apst, bool,0644 );MODULE_PARM_DESC (force_apst,"allow APST for newly enumerated devices even if quirked off" ); +static bool streams; +module_param (streams, bool,0644 ); +MODULE_PARM_DESC (stream,"turn on support for Streams write directives" ); +struct workqueue_struct *nvme_wq;EXPORT_SYMBOL_GPL (nvme_wq);
@@ -297,6 +301,102 @@ struct request *nvme_alloc_request(struct request_queue *q, }EXPORT_SYMBOL_GPL (nvme_alloc_request); +static int nvme_enable_streams (struct nvme_ctrl *ctrl) +{ +struct nvme_command c; + +memset (&c,0 ,sizeof (c)); + + c.directive.opcode = nvme_admin_directive_send; + c.directive.nsid =cpu_to_le32 (0xffffffff ); + c.directive.doper =NVME_DIR_SND_ID_OP_ENABLE ; + c.directive.dtype =NVME_DIR_IDENTIFY ; + c.directive.tdtype =NVME_DIR_STREAMS ; + c.directive.endir =NVME_DIR_ENDIR ; + +return nvme_submit_sync_cmd (ctrl->admin_q, &c,NULL ,0 ); +} + +static int nvme_get_stream_params (struct nvme_ctrl *ctrl, +struct streams_directive_params *s,u32 nsid) +{ +struct nvme_command c; + +memset (&c,0 ,sizeof (c)); +memset (s,0 ,sizeof (*s)); + + c.directive.opcode = nvme_admin_directive_recv; + c.directive.nsid =cpu_to_le32 (nsid); + c.directive.numd =sizeof (*s); + c.directive.doper =NVME_DIR_RCV_ST_OP_PARAM ; + c.directive.dtype =NVME_DIR_STREAMS ; + +return nvme_submit_sync_cmd (ctrl->admin_q, &c, s,sizeof (*s)); +} + +static int nvme_configure_directives (struct nvme_ctrl *ctrl) +{ +struct streams_directive_params s; +int ret; + +if (!(ctrl->oacs &NVME_CTRL_OACS_DIRECTIVES )) +return 0 ; +if (!streams) +return 0 ; + + ret =nvme_enable_streams (ctrl); +if (ret) +return ret; + + ret =nvme_get_stream_params (ctrl, &s,0xffffffff ); +if (ret) +return ret; + + ctrl->nssa =le16_to_cpu (s.nssa); + ctrl->nr_streams =min_t (unsigned, ctrl->nssa,BLK_MAX_WRITE_HINTS -1 ); +return 0 ; +} + +/* +* Write hint number to stream mappings +*/ +static const unsigned int stream_mappings[BLK_MAX_WRITE_HINTS ][BLK_MAX_WRITE_HINTS ] = { +/* 0 or 1 stream, we don't use streams */ + {0 , }, + {0 , }, +/* collapse short+medium to short, and long+extreme to medium */ + {WRITE_LIFE_NONE ,WRITE_LIFE_SHORT ,WRITE_LIFE_SHORT , +WRITE_LIFE_MEDIUM ,WRITE_LIFE_MEDIUM }, +/* collapse long+extreme to long */ + {WRITE_LIFE_NONE ,WRITE_LIFE_SHORT ,WRITE_LIFE_MEDIUM , +WRITE_LIFE_LONG ,WRITE_LIFE_LONG }, +/* 4 streams, no collapsing needed */ + {WRITE_LIFE_NONE ,WRITE_LIFE_SHORT ,WRITE_LIFE_MEDIUM , +WRITE_LIFE_LONG ,WRITE_LIFE_EXTREME }, +}; + +/* +* Check if 'req' has a write hint associated with it. If it does, assign +* a valid namespace stream to the write. If we haven't setup streams yet, +* kick off configuration and ignore the hints until that has completed. +*/ +static void nvme_assign_write_stream (struct nvme_ctrl *ctrl, +struct request *req,u16 *control, +u32 *dsmgmt) +{ +enum rw_hint streamid; + + streamid =opf_to_write_hint (req->cmd_flags); +if (streamid !=WRITE_LIFE_NONE ) { + streamid = stream_mappings[ctrl->nr_streams][streamid -1 ]; + *control |=NVME_RW_DTYPE_STREAMS ; + *dsmgmt |= streamid <<16 ; + } + +if (streamid <ARRAY_SIZE (req->q->write_hints)) + req->q->write_hints[streamid] +=blk_rq_bytes (req) >>9 ; +} +static inline void nvme_setup_flush (struct nvme_ns *ns,struct nvme_command *cmnd) {
@@ -348,6 +448,7 @@ static blk_status_t nvme_setup_discard(struct nvme_ns *ns, struct request *req,static inline blk_status_t nvme_setup_rw (struct nvme_ns *ns,struct request *req,struct nvme_command *cmnd) { +struct nvme_ctrl *ctrl = ns->ctrl;u16 control =0 ;u32 dsmgmt =0 ;
@@ -375,6 +476,9 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns, cmnd->rw.slba =cpu_to_le64 (nvme_block_nr (ns,blk_rq_pos (req))); cmnd->rw.length =cpu_to_le16 ((blk_rq_bytes (req) >> ns->lba_shift) -1 ); +if (req_op (req) ==REQ_OP_WRITE && ctrl->nr_streams) +nvme_assign_write_stream (ctrl, req, &control, &dsmgmt); +if (ns->ms) {switch (ns->pi_type) {case NVME_NS_DPS_PI_TYPE3 :
@@ -1094,8 +1198,15 @@ static void nvme_config_discard(struct nvme_ns *ns)BUILD_BUG_ON (PAGE_SIZE /sizeof (struct nvme_dsm_range ) <NVME_DSM_MAX_RANGES ); - ns->queue->limits.discard_alignment = logical_block_size; - ns->queue->limits.discard_granularity = logical_block_size; +if (ctrl->nr_streams && ns->sws && ns->sgs) { +unsigned int sz = logical_block_size * ns->sws * ns->sgs; + + ns->queue->limits.discard_alignment = sz; + ns->queue->limits.discard_granularity = sz; + }else { + ns->queue->limits.discard_alignment = logical_block_size; + ns->queue->limits.discard_granularity = logical_block_size; + }blk_queue_max_discard_sectors (ns->queue,UINT_MAX );blk_queue_max_discard_segments (ns->queue,NVME_DSM_MAX_RANGES );queue_flag_set_unlocked (QUEUE_FLAG_DISCARD , ns->queue);
@@ -1135,6 +1246,7 @@ static int nvme_revalidate_ns(struct nvme_ns *ns, struct nvme_id_ns **id)static void __nvme_revalidate_disk (struct gendisk *disk,struct nvme_id_ns *id) {struct nvme_ns *ns = disk->private_data; +struct nvme_ctrl *ctrl = ns->ctrl;u16 bs;/*
@@ -1149,7 +1261,7 @@ static void __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id)blk_mq_freeze_queue (disk->queue); -if (ns->ctrl->ops->flags &NVME_F_METADATA_SUPPORTED ) +if (ctrl->ops->flags &NVME_F_METADATA_SUPPORTED )nvme_prep_integrity (disk, id, bs);blk_queue_logical_block_size (ns->queue, bs);if (ns->noiob)
@@ -1161,7 +1273,7 @@ static void __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id)else set_capacity (disk,le64_to_cpup (&id->nsze) << (ns->lba_shift -9 )); -if (ns->ctrl->oncs &NVME_CTRL_ONCS_DSM ) +if (ctrl->oncs &NVME_CTRL_ONCS_DSM )nvme_config_discard (ns);blk_mq_unfreeze_queue (disk->queue); }
@@ -1766,6 +1878,7 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)dev_pm_qos_hide_latency_tolerance (ctrl->device);nvme_configure_apst (ctrl); +nvme_configure_directives (ctrl); ctrl->identified = true;
@@ -2158,6 +2271,32 @@ static struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)return ret; } +static int nvme_setup_streams_ns (struct nvme_ctrl *ctrl,struct nvme_ns *ns) +{ +struct streams_directive_params s; +int ret; + +if (!ctrl->nr_streams) +return 0 ; + + ret =nvme_get_stream_params (ctrl, &s, ns->ns_id); +if (ret) +return ret; + + ns->sws =le32_to_cpu (s.sws); + ns->sgs =le16_to_cpu (s.sgs); + +if (ns->sws) { +unsigned int bs =1 << ns->lba_shift; + +blk_queue_io_min (ns->queue, bs * ns->sws); +if (ns->sgs) +blk_queue_io_opt (ns->queue, bs * ns->sws * ns->sgs); + } + +return 0 ; +} +static void nvme_alloc_ns (struct nvme_ctrl *ctrl,unsigned nsid) {struct nvme_ns *ns;
@@ -2187,6 +2326,7 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid)blk_queue_logical_block_size (ns->queue,1 << ns->lba_shift);nvme_set_queue_limits (ctrl, ns->queue); +nvme_setup_streams_ns (ctrl, ns);sprintf (disk_name,"nvme%dn%d" , ctrl->instance, ns->instance);
drivers/nvme/host/nvme.h +4 -0
@@ -147,6 +147,8 @@ struct nvme_ctrl {u16 oncs;u16 vid;u16 oacs; +u16 nssa; +u16 nr_streams;atomic_t abort_limit;u8 event_limit;u8 vwc;
@@ -199,6 +201,8 @@ struct nvme_ns {unsigned ns_id;int lba_shift;u16 ms; +u16 sgs; +u32 sws;bool ext;u8 pi_type;unsigned long flags;
include/linux/nvme.h +48 -0
90 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
In reply to Jens AxboeThe API looks ok, but the code could use some cleanups. What do you think about the incremental patch below:
It refactors various manipulations, and stores the write hint right in the iocb as there is a 4 byte hole (this will need some minor adjustments in the next patches):
fs/fcntl.c +63 -0
@@ -243,6 +243,63 @@ static int f_getowner_uids(struct file *filp, unsigned long arg) }#endif +static bool rw_hint_valid (enum rw_hint hint) +{ +switch (hint) { +case RWF_WRITE_LIFE_NOT_SET : +case RWH_WRITE_LIFE_NONE : +case RWH_WRITE_LIFE_SHORT : +case RWH_WRITE_LIFE_MEDIUM : +case RWH_WRITE_LIFE_LONG : +case RWH_WRITE_LIFE_EXTREME : +return true; +default : +return false; + } +} + +static long fcntl_rw_hint (struct file *file,unsigned int cmd, +unsigned long arg) +{ +struct inode *inode =file_inode (file); +u64 *argp = (u64 __user *)arg; +enum rw_hint hint; + +switch (cmd) { +case F_GET_FILE_RW_HINT : +if (put_user (__file_write_hint (file), argp)) +return -EFAULT ; +return 0 ; +case F_SET_FILE_RW_HINT : +if (get_user (hint, argp)) +return -EFAULT ; +if (!rw_hint_valid (hint)) +return -EINVAL ; + +spin_lock (&file->f_lock); + file->f_write_hint = hint; +spin_unlock (&file->f_lock); +return 0 ; +case F_GET_RW_HINT : +if (put_user (__inode_write_hint (inode), argp)) +return -EFAULT ; +return 0 ; +case F_SET_RW_HINT : +if (get_user (hint, argp)) +return -EFAULT ; +if (!rw_hint_valid (hint)) +return -EINVAL ; + +inode_lock (inode); +inode_set_flags (inode, hint <<S_WRITE_LIFE_SHIFT , +S_WRITE_LIFE_MASK ); +inode_unlock (inode); +return 0 ; +default : +return -EINVAL ; + } +} +static long do_fcntl (int fd,unsigned int cmd,unsigned long arg,struct file *filp) {
@@ -337,6 +394,12 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,case F_GET_SEALS : err =shmem_fcntl (filp, cmd, arg);break ; +case F_GET_RW_HINT : +case F_SET_RW_HINT : +case F_GET_FILE_RW_HINT : +case F_SET_FILE_RW_HINT : + err =fcntl_rw_hint (filp, cmd, arg); +break ;default :break ; }
fs/open.c +1 -0
@@ -759,6 +759,7 @@ static int do_dentry_open(struct file *f, likely(f->f_op->write || f->f_op->write_iter)) f->f_mode |= FMODE_CAN_WRITE; + f->f_write_hint =WRITE_LIFE_NOT_SET ; f->f_flags &= ~(O_CREAT |O_EXCL |O_NOCTTY |O_TRUNC );file_ra_state_init (&f->f_ra, f->f_mapping->host->i_mapping);
include/linux/fs.h +51 -0
81 lines not on this page · raw message
include/uapi/linux/fcntl.h +21 -0
@@ -43,6 +43,27 @@/* (1U << 31) is reserved for signed error codes */ /* +* Set/Get write life time hints. {GET,SET}_RW_HINT operate on the +* underlying inode, while {GET,SET}_FILE_RW_HINT operate only on +* the specific file. +*/ +#define F_GET_RW_HINT (F_LINUX_SPECIFIC_BASE + 11) +#define F_SET_RW_HINT (F_LINUX_SPECIFIC_BASE + 12) +#define F_GET_FILE_RW_HINT (F_LINUX_SPECIFIC_BASE + 13) +#define F_SET_FILE_RW_HINT (F_LINUX_SPECIFIC_BASE + 14) + +/* +* Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be +* used to clear any hints previously set. +*/ +#define RWF_WRITE_LIFE_NOT_SET 0 +#define RWH_WRITE_LIFE_NONE 1 +#define RWH_WRITE_LIFE_SHORT 2 +#define RWH_WRITE_LIFE_MEDIUM 3 +#define RWH_WRITE_LIFE_LONG 4 +#define RWH_WRITE_LIFE_EXTREME 5 + +/* * Types of directory notifications that may be requested. */ #define DN_ACCESS 0x00000001/* File accessed */
Re: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
Quoted 6 lines · Christoph Hellwig
The API looks ok, but the code could use some cleanups. What do you think about the incremental patch below:
It refactors various manipulations, and stores the write hint right in the iocb as there is a 4 byte hole (this will need some minor adjustments in the next patches):
And looking over the followons I'd love to just store the hints directly in the inode, bio and request themselves. We have big enough holes at least in the bio and request to store them, although instead of the enum which is at least in sized we'd have to make them an explicit u16 or even u8.
Re: [PATCH 4/9] fs: add O_DIRECT support for sending down write life time hints
In reply to Jens Axboefs/iomap.c iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, · line 807
Quoted 3 lines
fs/iomap.c +2
-1-bio_set_op_attrs (bio,REQ_OP_WRITE ,REQ_SYNC |REQ_IDLE ); +bio_set_op_attrs (bio,REQ_OP_WRITE , +REQ_SYNC |REQ_IDLE );
bio->bi_opf = REQ_OP_WRITE | REQ_SYNC | REQ_IDLE;
Jens Axboe
maintainerRe: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
In reply to Christoph HellwigQuoted 6 lines · Christoph Hellwig
The API looks ok, but the code could use some cleanups. What do you think about the incremental patch below:
It refactors various manipulations, and stores the write hint right in the iocb as there is a 4 byte hole (this will need some minor adjustments in the next patches):
Sigh... Sure, that's how I did it originally as well.
BTW, that patch does not look like an incremental patch, what's this against?
Signature · 1 line
Jens Axboe
Christoph Hellwig
maintainerRe: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
Quoted 2 lines · Jens Axboe
BTW, that patch does not look like an incremental patch, what's this against?
The patch I'm replying to, without the other ones.
Jens Axboe
maintainerRe: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
Quoted 5 lines · Christoph Hellwig
Quoted 2 lines · Jens Axboe
BTW, that patch does not look like an incremental patch, what's this against?
The patch I'm replying to, without the other ones.
Looks like a replacement patch, not incremental to that. I'll update. And I'm fine with not using flags, in fact that's what I preferred to do initially.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerRe: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
In reply to Christoph HellwigQuoted 6 lines · Christoph Hellwig
The API looks ok, but the code could use some cleanups. What do you think about the incremental patch below:
It refactors various manipulations, and stores the write hint right in the iocb as there is a 4 byte hole (this will need some minor adjustments in the next patches):
How's this? Fixes for compile, and also squeeze an enum rw_hint into a hole in the inode structure.
I'll refactor around this and squeeze into bio/rq holes as well, then re-test it.
fs/fcntl.c +62 -0
@@ -243,6 +243,62 @@ static int f_getowner_uids(struct file *filp, unsigned long arg) }#endif +static bool rw_hint_valid (enum rw_hint hint) +{ +switch (hint) { +case RWF_WRITE_LIFE_NOT_SET : +case RWH_WRITE_LIFE_NONE : +case RWH_WRITE_LIFE_SHORT : +case RWH_WRITE_LIFE_MEDIUM : +case RWH_WRITE_LIFE_LONG : +case RWH_WRITE_LIFE_EXTREME : +return true; +default : +return false; + } +} + +static long fcntl_rw_hint (struct file *file,unsigned int cmd, +unsigned long arg) +{ +struct inode *inode =file_inode (file); +u64 *argp = (u64 __user *)arg; +enum rw_hint hint; + +switch (cmd) { +case F_GET_FILE_RW_HINT : +if (put_user (__file_write_hint (file), argp)) +return -EFAULT ; +return 0 ; +case F_SET_FILE_RW_HINT : +if (get_user (hint, argp)) +return -EFAULT ; +if (!rw_hint_valid (hint)) +return -EINVAL ; + +spin_lock (&file->f_lock); + file->f_write_hint = hint; +spin_unlock (&file->f_lock); +return 0 ; +case F_GET_RW_HINT : +if (put_user (__inode_write_hint (inode), argp)) +return -EFAULT ; +return 0 ; +case F_SET_RW_HINT : +if (get_user (hint, argp)) +return -EFAULT ; +if (!rw_hint_valid (hint)) +return -EINVAL ; + +inode_lock (inode); + inode->i_write_hint = hint; +inode_unlock (inode); +return 0 ; +default : +return -EINVAL ; + } +} +static long do_fcntl (int fd,unsigned int cmd,unsigned long arg,struct file *filp) {
@@ -337,6 +393,12 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,case F_GET_SEALS : err =shmem_fcntl (filp, cmd, arg);break ; +case F_GET_RW_HINT : +case F_SET_RW_HINT : +case F_GET_FILE_RW_HINT : +case F_SET_FILE_RW_HINT : + err =fcntl_rw_hint (filp, cmd, arg); +break ;default :break ; }
fs/inode.c +1 -0
@@ -146,6 +146,7 @@ int inode_init_always(struct super_block *sb, struct inode *inode)i_gid_write (inode,0 );atomic_set (&inode->i_writecount,0 ); inode->i_size =0 ; + inode->i_write_hint =WRITE_LIFE_NOT_SET ; inode->i_blocks =0 ; inode->i_bytes =0 ; inode->i_generation =0 ;
fs/open.c +1 -0
@@ -759,6 +759,7 @@ static int do_dentry_open(struct file *f, likely(f->f_op->write || f->f_op->write_iter)) f->f_mode |= FMODE_CAN_WRITE; + f->f_write_hint =WRITE_LIFE_NOT_SET ; f->f_flags &= ~(O_CREAT |O_EXCL |O_NOCTTY |O_TRUNC );file_ra_state_init (&f->f_ra, f->f_mapping->host->i_mapping);
include/linux/fs.h +46 -2
84 lines not on this page · raw message
include/uapi/linux/fcntl.h +21 -0
@@ -43,6 +43,27 @@/* (1U << 31) is reserved for signed error codes */ /* +* Set/Get write life time hints. {GET,SET}_RW_HINT operate on the +* underlying inode, while {GET,SET}_FILE_RW_HINT operate only on +* the specific file. +*/ +#define F_GET_RW_HINT (F_LINUX_SPECIFIC_BASE + 11) +#define F_SET_RW_HINT (F_LINUX_SPECIFIC_BASE + 12) +#define F_GET_FILE_RW_HINT (F_LINUX_SPECIFIC_BASE + 13) +#define F_SET_FILE_RW_HINT (F_LINUX_SPECIFIC_BASE + 14) + +/* +* Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be +* used to clear any hints previously set. +*/ +#define RWF_WRITE_LIFE_NOT_SET 0 +#define RWH_WRITE_LIFE_NONE 1 +#define RWH_WRITE_LIFE_SHORT 2 +#define RWH_WRITE_LIFE_MEDIUM 3 +#define RWH_WRITE_LIFE_LONG 4 +#define RWH_WRITE_LIFE_EXTREME 5 + +/* * Types of directory notifications that may be requested. */ #define DN_ACCESS 0x00000001/* File accessed */
Signature · 1 line
Jens Axboe
Christoph Hellwig
maintainerRe: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
Quoted 8 lines · Jens Axboe
Quoted 6 lines · Christoph Hellwig
The API looks ok, but the code could use some cleanups. What do you think about the incremental patch below:
It refactors various manipulations, and stores the write hint right in the iocb as there is a 4 byte hole (this will need some minor adjustments in the next patches):
Quoted 5 lines
How's this? Fixes for compile, and also squeeze an enum
rw_hintinto a hole in the inode structure.I'll refactor around this and squeeze into bio/rq holes as well, then re-test it.
Looks good, minor nitpick below:
include/linux/fs.h struct page; · line 268
Quoted 8 lines
index
4574121f4746..4587a181162e100644include/linux/fs.h +1
-0@@ -265,6 +265,20 @@ struct page;struct address_space ;struct writeback_control ; +#include <linux/fcntl.h>
I didn't seem to need the move. But if you want to move it can we keep all the includes together at the very top?
Quoted 18 lines
include/linux/fs.h +18
-0+static inline enum rw_hint __inode_write_hint (struct inode *inode) +{ +return inode->i_write_hint; +} + +static inline enum rw_hint inode_write_hint (struct inode *inode) +{ +enum rw_hint ret =__inode_write_hint (inode); +if (ret !=WRITE_LIFE_NOT_SET ) +return ret; +return WRITE_LIFE_NONE ; +} + +static inline enum rw_hint __file_write_hint (struct file *file) +{ +if (file->f_write_hint !=WRITE_LIFE_NOT_SET ) +return file->f_write_hint; +
include/linux/fs.h static inline bool HAS_UNMAPPED_ID(struct inode *inode) · line 1923
Quoted 10 lines
include/linux/fs.h +10
-0+return __inode_write_hint (file_inode (file)); +} + +static inline enum rw_hint file_write_hint (struct file *file) +{ +enum rw_hint ret =__file_write_hint (file); +if (ret !=WRITE_LIFE_NOT_SET ) +return ret; +return WRITE_LIFE_NONE ; +}
I'd say kill all these helpers and just treat both WRITE_LIFE_NONE and WRITE_LIFE_NOT_SET special all the way down in NVMe.
Christoph Hellwig
maintainerRe: [PATCH 3/9] blk-mq: expose write hints through debugfs
In reply to Jens AxboeQuoted 7 lines · Jens Axboe
Useful to verify that things are working the way they should. Reading the file will return number of kb written with each write hint. Writing the file will reset the statistics. No care is taken to ensure that we don't race on updates.
Drivers will write to q->write_hints[] if they handle a given write hint.
How about moving the accounting itself to blk-mq as well? Just noticed that it's completely generic while looking over the nvme patch.
Jens Axboe
maintainerRe: [PATCH 1/9] fs: add fcntl() interface for setting/getting write life time hints
In reply to Christoph HellwigQuoted 24 lines · Christoph Hellwig
Quoted 8 lines · Jens Axboe
Quoted 6 lines · Christoph Hellwig
The API looks ok, but the code could use some cleanups. What do you think about the incremental patch below:
It refactors various manipulations, and stores the write hint right in the iocb as there is a 4 byte hole (this will need some minor adjustments in the next patches):
Quoted 5 lines
How's this? Fixes for compile, and also squeeze an enum
rw_hintinto a hole in the inode structure.I'll refactor around this and squeeze into bio/rq holes as well, then re-test it.
Looks good, minor nitpick below:
Quoted 7 lines
index
4574121f4746..4587a181162e100644include/linux/fs.h +0
-0@@ -265,6 +265,20 @@ struct page;struct address_space ;struct writeback_control ;
Quoted 4 lines
include/linux/fs.h struct page; · line 268
Quoted 1 line
include/linux/fs.h +1
-0+#include <linux/fcntl.h> I didn't seem to need the move. But if you want to move it can we keep all the includes together at the very top?
It did here, we need it for the RWH_ defines or my compile blows up. But yeah, let's just move it to the top, not sure why it's in the middle.
Quoted 23 lines
Quoted 23 lines
include/linux/fs.h +23
-0+static inline enum rw_hint __inode_write_hint (struct inode *inode) +{ +return inode->i_write_hint; +} + +static inline enum rw_hint inode_write_hint (struct inode *inode) +{ +enum rw_hint ret =__inode_write_hint (inode); +if (ret !=WRITE_LIFE_NOT_SET ) +return ret; +return WRITE_LIFE_NONE ; +} + +static inline enum rw_hint __file_write_hint (struct file *file) +{ +if (file->f_write_hint !=WRITE_LIFE_NOT_SET ) +return file->f_write_hint; + +return __inode_write_hint (file_inode (file)); +} + +static inline enum rw_hint file_write_hint (struct file *file) +{
Quoted 8 lines
include/linux/fs.h static inline bool HAS_UNMAPPED_ID(struct inode *inode) · line 1923
Quoted 5 lines
include/linux/fs.h +5
-0+enum rw_hint ret =__file_write_hint (file); +if (ret !=WRITE_LIFE_NOT_SET ) +return ret; +return WRITE_LIFE_NONE ; +}I'd say kill all these helpers and just treat both
WRITE_LIFE_NONEandWRITE_LIFE_NOT_SETspecial all the way down in NVMe.
Sure, we can do that.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerRe: [PATCH 3/9] blk-mq: expose write hints through debugfs
In reply to Christoph HellwigQuoted 11 lines · Christoph Hellwig
Quoted 7 lines · Jens Axboe
Useful to verify that things are working the way they should. Reading the file will return number of kb written with each write hint. Writing the file will reset the statistics. No care is taken to ensure that we don't race on updates.
Drivers will write to q->write_hints[] if they handle a given write hint.
How about moving the accounting itself to blk-mq as well? Just noticed that it's completely generic while looking over the nvme patch.
I didn't want to do it, unless the driver is using streams.
Signature · 1 line
Jens Axboe