Skip to contentSkip to conversation

lib/cfl: Add Coffeelake PCI IDs for S SKU.

PATCH RESEND In review Anusha Srivatsa 2 participants 4 messages Jun 29, 2017 Library code

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/3 lib/cfl: Add Coffeelake PCI IDs for S SKU.

Just following the spec and adding these extra IDs.

v2: update IDs following the kernel commit:
b056f8f3d6b900e8afd19f312719160346d263b4 (Chris)

---
 lib/i915_pciids.h       | 10 ++++++++++
 lib/intel_device_info.c |  2 ++
 2 files changed, 12 insertions(+)
lib/i915_pciids.h +10 -0
index 27e0dba..02f43d9 100644
@@ -334,4 +334,14 @@
 	INTEL_KBL_GT3_IDS(info), \
 	INTEL_KBL_GT4_IDS(info)
 
+#define INTEL_CFL_S_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
+
+#define INTEL_CFL_IDS(info) \
+	INTEL_CFL_S_IDS(info)
+
 #endif /* _I915_PCIIDS_H */
lib/intel_device_info.c +2 -0
index 199fa2d..2c46aba 100644
@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {
 
 	INTEL_GLK_IDS(&intel_geminilake_info),
 
+	INTEL_CFL_IDS(&intel_coffeelake_info),
+
 	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
 };
 
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH RESEND 2/3 lib/cfl: Add PCI IDs to H SKU in CFl

Follow the spec and add the ID for H SKU in
CFL.

v2: Update IDs following kernel commit:
ccfd13215fd25a0e8c28221f3acc0dcaec11cd15 (Chris)

---
 lib/i915_pciids.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
lib/i915_pciids.h +7 -1
index 02f43d9..c319e37 100644
@@ -341,7 +341,13 @@
 	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
 	INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
 
+
+#define INTEL_CFL_H_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
+	INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
+
 #define INTEL_CFL_IDS(info) \
-	INTEL_CFL_S_IDS(info)
+	INTEL_CFL_S_IDS(info), \
+	INTEL_CFL_H_IDS(info)
 
 #endif /* _I915_PCIIDS_H */
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH RESEND 3/3 lib/cfl: Add PCI Ids for U SKU in CFl

In reply to Anusha Srivatsa

Follow the spec and add ID for U SKU

v2: Update IDs in accordance to the kernel commit:
d29fe702c9cb682df99146d24d06e5455f043101 (Chris)

---
 lib/i915_pciids.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
lib/i915_pciids.h +8 -1
index c319e37..71cce60 100644
@@ -346,8 +346,15 @@
 	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
 
+#define INTEL_CFL_U_IDS(info) \
+	INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
+
 #define INTEL_CFL_IDS(info) \
 	INTEL_CFL_S_IDS(info), \
-	INTEL_CFL_H_IDS(info)
+	INTEL_CFL_H_IDS(info), \
+	INTEL_CFL_U_IDS(info)
 
 #endif /* _I915_PCIIDS_H */
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Re: [RESEND i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl

series merged. thanks for the patches and reviews.

Quoted 23 lines · Anusha Srivatsa

Follow the spec and add ID for U SKU

v2: Update IDs in accordance to the kernel commit:
d29fe702c9cb682df99146d24d06e5455f043101 (Chris)

---
 lib/i915_pciids.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
lib/i915_pciids.h +3 -0
index c319e37..71cce60 100644
@@ -346,8 +346,15 @@
 	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
 
+#define INTEL_CFL_U_IDS(info) \
+	INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \

lib/i915_pciids.h line 360

Quoted 10 lines
lib/i915_pciids.h +5 -1
+	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
+
 #define INTEL_CFL_IDS(info) \
 	INTEL_CFL_S_IDS(info), \
-	INTEL_CFL_H_IDS(info)
+	INTEL_CFL_H_IDS(info), \
+	INTEL_CFL_U_IDS(info)
 
 #endif /* _I915_PCIIDS_H */

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx