Patch "sctp: disable BH in sctp_for_each_endpoint" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
sctp: disable BH in sctp_for_each_endpoint
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
sctp-disable-bh-in-sctp_for_each_endpoint.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Jun 29 18:57:46 CEST 2017
From: Xin Long <[email protected]>
Date: Sat, 10 Jun 2017 14:48:14 +0800
Subject: sctp: disable BH in sctp_for_each_endpoint
From: Xin Long <[email protected]>
[ Upstream commit 581409dacc9176b0de1f6c4ca8d66e13aa8e1b29 ]
Now sctp holds read_lock when foreach sctp_ep_hashtable without disabling BH. If CPU schedules to another thread A at this moment, the thread A may be trying to hold the write_lock with disabling BH.
As BH is disabled and CPU cannot schedule back to the thread holding the read_lock, while the thread A keeps waiting for the read_lock. A dead lock would be triggered by this.
This patch is to fix this dead lock by calling read_lock_bh instead to disable BH when holding the read_lock in sctp_for_each_endpoint.
--- net/sctp/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/sctp/socket.c +2 -2
@@ -4460,13 +4460,13 @@ int sctp_for_each_endpoint(int (*cb)(strfor (head = sctp_ep_hashtable; hash < sctp_ep_hashsize; hash++, head++) { -read_lock (&head->lock); +read_lock_bh (&head->lock);sctp_for_each_hentry (epb, &head->chain) { err =cb (sctp_ep (epb), p);if (err)break ; } -read_unlock (&head->lock); +read_unlock_bh (&head->lock); }return err;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/ipv6-fix-calling-in6_ifa_hold-incorrectly-for-dad-work.patch queue-4.9/igmp-acquire-pmc-lock-for-ip_mc_clear_src.patch queue-4.9/sctp-return-next-obj-by-passing-pos-1-into-sctp_transport_get_idx.patch queue-4.9/sctp-disable-bh-in-sctp_for_each_endpoint.patch