Patch "sfc: provide dummy definitions of vswitch functions" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
sfc: provide dummy definitions of vswitch functions
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
sfc-provide-dummy-definitions-of-vswitch-functions.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Jun 29 19:38:17 CEST 2017
From: Bert Kenward <[email protected]>
Date: Fri, 16 Jun 2017 09:45:08 +0100
Subject: sfc: provide dummy definitions of vswitch functions
From: Bert Kenward <[email protected]>
efx_probe_all() calls efx->type->vswitching_probe during probe. For SFC4000 (Falcon) NICs this function is not defined, leading to a BUG with the top of the call stack similar to:
? efx_pci_probe_main+0x29a/0x830 efx_pci_probe+0x7d3/0xe70
vswitching_restore and vswitching_remove also need to be defined.
Fixed in mainline by:
commit 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
--- drivers/net/ethernet/sfc/falcon.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/ethernet/sfc/falcon.c +10 -0
@@ -2796,6 +2796,11 @@ const struct efx_nic_type falcon_a1_nic_ .timer_period_max = 1 << FRF_AB_TC_TIMER_VAL_WIDTH, .offload_features = NETIF_F_IP_CSUM, .mcdi_max_ver =-1 , +#ifdef CONFIG_SFC_SRIOV + .vswitching_probe = efx_port_dummy_op_int, + .vswitching_restore = efx_port_dummy_op_int, + .vswitching_remove = efx_port_dummy_op_void, +#endif }; const struct efx_nic_type falcon_b0_nic_type = {
@@ -2897,4 +2902,9 @@ const struct efx_nic_type falcon_b0_nic_ .offload_features = NETIF_F_IP_CSUM | NETIF_F_RXHASH | NETIF_F_NTUPLE, .mcdi_max_ver = -1, .max_rx_ip_filters =FR_BZ_RX_FILTER_TBL0_ROWS , +#ifdef CONFIG_SFC_SRIOV + .vswitching_probe = efx_port_dummy_op_int, + .vswitching_restore = efx_port_dummy_op_int, + .vswitching_remove = efx_port_dummy_op_void, +#endif };
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/sfc-provide-dummy-definitions-of-vswitch-functions.patch