Skip to contentSkip to conversation

Patch "net: phy: add an option to disable EEE advertisement" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: phy: add an option to disable EEE advertisement

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-phy-add-an-option-to-disable-eee-advertisement.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jul 3 11:00:33 CEST 2017

From: jbrunet <[email protected]>
Date: Mon, 28 Nov 2016 10:46:46 +0100
Subject: net: phy: add an option to disable EEE advertisement

From: jbrunet <[email protected]>

[ Upstream commit d853d145ea3e63387a2ac759aa41d5e43876e561 ]

This patch adds an option to disable EEE advertisement in the generic PHY by providing a mask of prohibited modes corresponding to the value found in the MDIO_AN_EEE_ADV register.

On some platforms, PHY Low power idle seems to be causing issues, even breaking the link some cases. The patch provides a convenient way for these platforms to disable EEE advertisement and work around the issue.

---
 drivers/net/phy/phy.c        |    3 +
 drivers/net/phy/phy_device.c |   80 ++++++++++++++++++++++++++++++++++++++-----
 include/linux/phy.h          |    3 +
 3 files changed, 77 insertions(+), 9 deletions(-)
drivers/net/phy/phy.c +3 -0
@@ -1384,6 +1384,9 @@ int phy_ethtool_set_eee(struct phy_devic
 {
 	int val = ethtool_adv_to_mmd_eee_adv_t(data->advertised);
 
+	/* Mask prohibited EEE modes */
+	val &= ~phydev->eee_broken_modes;
+
 	phy_write_mmd_indirect(phydev, MDIO_AN_EEE_ADV, MDIO_MMD_AN, val);
 
 	return 0;
drivers/net/phy/phy_device.c +71 -9

120 lines not on this page · raw message

include/linux/phy.h +3 -0
@@ -401,6 +401,9 @@ struct phy_device {
 	u32 advertising;
 	u32 lp_advertising;
 
+	/* Energy efficient ethernet modes which should be prohibited */
+	u32 eee_broken_modes;
+
 	int autoneg;
 
 	int link_timeout;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/net-phy-add-an-option-to-disable-eee-advertisement.patch queue-4.9/dt-bindings-net-add-eee-capability-constants.patch queue-4.9/net-phy-use-boolean-dt-properties-for-eee-broken-modes.patch queue-4.9/arm64-dts-meson-gxbb-odroidc2-fix-gbe-tx-link-breakage.patch queue-4.9/net-phy-fix-sign-type-error-in-genphy_config_eee_advert.patch queue-4.9/dt-bindings-net-use-boolean-dt-properties-for-eee-broken-modes.patch