Patch "net: sctp: fix array overrun read on sctp_timer_tbl" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net: sctp: fix array overrun read on sctp_timer_tbl
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-sctp-fix-array-overrun-read-on-sctp_timer_tbl.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Jul 3 13:09:11 CEST 2017
From: Colin Ian King <[email protected]>
Date: Fri, 20 Jan 2017 13:01:57 +0000
Subject: net: sctp: fix array overrun read on sctp_timer_tbl
From: Colin Ian King <[email protected]>
[ Upstream commit 0e73fc9a56f22f2eec4d2b2910c649f7af67b74d ]
The comparison on the timeout can lead to an array overrun read on sctp_timer_tbl because of an off-by-one error. Fix this by using < instead of <= and also compare to the array size rather than SCTP_EVENT_TIMEOUT_MAX.
Fixes CoverityScan CID#1397639 ("Out-of-bounds read")
--- net/sctp/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sctp/debug.c +1 -1
@@ -166,7 +166,7 @@ static const char *const sctp_timer_tbl[/* Lookup timer debug name. */ const char *sctp_tname (const sctp_subtype_t id) { -if (id.timeout <=SCTP_EVENT_TIMEOUT_MAX ) +if (id.timeout <ARRAY_SIZE (sctp_timer_tbl))return sctp_timer_tbl[id.timeout];return "unknown_timer" ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/net-sctp-fix-array-overrun-read-on-sctp_timer_tbl.patch