Skip to contentSkip to conversation

Patch "be2net: don't delete MAC on close on unprivileged BE3 VFs" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

be2net: don't delete MAC on close on unprivileged BE3 VFs

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
be2net-don-t-delete-mac-on-close-on-unprivileged-be3-vfs.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jul 3 13:37:32 CEST 2017

From: Ivan Vecera <[email protected]>
Date: Fri, 13 Jan 2017 22:38:28 +0100
Subject: be2net: don't delete MAC on close on unprivileged BE3 VFs

From: Ivan Vecera <[email protected]>

[ Upstream commit 6d928ae590c8d58cfd5cca997d54394de139cbb7 ]

BE3 VFs without FILTMGMT privilege are not allowed to modify its MAC, VLAN table and UC/MC lists. So don't try to delete MAC on such VFs.

---
 drivers/net/ethernet/emulex/benet/be_main.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/ethernet/emulex/benet/be_main.c +5 -1
@@ -3630,7 +3630,11 @@ static void be_rx_qs_destroy(struct be_a
 
 static void be_disable_if_filters(struct be_adapter *adapter)
 {
-	be_dev_mac_del(adapter, adapter->pmac_id[0]);
+	/* Don't delete MAC on BE3 VFs without FILTMGMT privilege  */
+	if (!BEx_chip(adapter) || !be_virtfn(adapter) ||
+	    check_privilege(adapter, BE_PRIV_FILTMGMT))
+		be_dev_mac_del(adapter, adapter->pmac_id[0]);
+
 	be_clear_uc_list(adapter);
 	be_clear_mc_list(adapter);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/be2net-don-t-delete-mac-on-close-on-unprivileged-be3-vfs.patch queue-4.9/be2net-fix-status-check-in-be_cmd_pmac_add.patch queue-4.9/be2net-fix-mac-addr-setting-on-privileged-be3-vfs.patch