Skip to contentSkip to conversation

Patch "perf/x86: Reject non sampling events with precise_ip" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

perf/x86: Reject non sampling events with precise_ip

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
perf-x86-reject-non-sampling-events-with-precise_ip.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jul 3 13:33:55 CEST 2017

From: Jiri Olsa <[email protected]>
Date: Tue, 3 Jan 2017 15:24:54 +0100
Subject: perf/x86: Reject non sampling events with precise_ip

From: Jiri Olsa <[email protected]>

[ Upstream commit 18e7a45af91acdde99d3aa1372cc40e1f8142f7b ]

As Peter suggested [1] rejecting non sampling PEBS events, because they dont make any sense and could cause bugs in the NMI handler [2].

[1] http://lkml.kernel.org/r/20170103094059.GC3093@worktop
[2] http://lkml.kernel.org/r/[email protected]

Cc Alexander Shishkin <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vince Weaver <[email protected]>
Cc Vince Weaver <[email protected]>
---
 arch/x86/events/core.c |    4 ++++
 1 file changed, 4 insertions(+)
arch/x86/events/core.c +4 -0
@@ -505,6 +505,10 @@ int x86_pmu_hw_config(struct perf_event
 
 		if (event->attr.precise_ip > precise)
 			return -EOPNOTSUPP;
+
+		/* There's no sense in having PEBS for non sampling events: */
+		if (!is_sampling_event(event))
+			return -EINVAL;
 	}
 	/*
 	 * check that PEBS LBR correction does not conflict with

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/perf-x86-reject-non-sampling-events-with-precise_ip.patch queue-4.9/perf-probe-fix-to-probe-on-gcc-generated-functions-in-modules.patch queue-4.9/perf-core-fix-sys_perf_event_open-vs.-hotplug.patch queue-4.9/perf-x86-intel-uncore-fix-hardcoded-socket-0-assumption-in-the-haswell-init-code.patch queue-4.9/perf-probe-fix-to-show-correct-locations-for-events-on-modules.patch