Patch "infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data" has been added to the 4.11-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
infiniband-hns-avoid-gcc-7.0.1-warning-for-uninitialized-data.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
5b0ff9a00755d4d9c209033a77f1ed8f3186fe5cMon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Fri, 24 Mar 2017 23:02:48 +0100
Subject: infiniband: hns: avoid gcc-7.0.1 warning for uninitialized data
From: Arnd Bergmann <[email protected]>
commit 5b0ff9a00755d4d9c209033a77f1ed8f3186fe5c upstream.
hns_roce_v1_cq_set_ci() calls roce_set_bit() on an uninitialized field, which will then change only a few of its bits, causing a warning with the latest gcc:
infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_cq_set_ci':infiniband/hw/hns/hns_roce_hw_v1.c:1854:23: error: 'doorbell[1]' is used uninitialized in this function [-Werror=uninitialized]
roce_set_bit(doorbell[1], ROCEE_DB_OTHERS_H_ROCEE_DB_OTH_HW_SYNS_S, 1);
The code is actually correct since we always set all bits of the port_vlan field, but gcc correctly points out that the first access does contain uninitialized data.
This initializes the field to zero first before setting the individual bits.
--- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 + 1 file changed, 1 insertion(+)
drivers/infiniband/hw/hns/hns_roce_hw_v1.c +1 -0
@@ -1851,6 +1851,7 @@ void hns_roce_v1_cq_set_ci(struct hns_rou32 doorbell[2 ]; doorbell[0 ] = cons_index & ((hr_cq->cq_depth <<1 ) -1 ); + doorbell[1 ] =0 ;roce_set_bit (doorbell[1 ],ROCEE_DB_OTHERS_H_ROCEE_DB_OTH_HW_SYNS_S ,1 );roce_set_field (doorbell[1 ],ROCEE_DB_OTHERS_H_ROCEE_DB_OTH_CMD_M ,ROCEE_DB_OTHERS_H_ROCEE_DB_OTH_CMD_S ,3 );
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/infiniband-hns-avoid-gcc-7.0.1-warning-for-uninitialized-data.patch