i2c: rk3x: add Kconfig dependency on COMMON_CLK
PATCH 1/1 i2c: rk3x: add Kconfig dependency on COMMON_CLK
Now that we are using the clk notifier framework we get compile errors without COMMON_CLK. But the driver fails to probe without COMMON_CLK anyways, so just add that as a Kconfig dependency.
---
As reported by the kbuild test robot at Intel Open Source.
drivers/i2c/busses/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
@@ -720,7 +720,7 @@ config I2C_RIIC config I2C_RK3X tristate "Rockchip RK3xxx I2C adapter" - depends on OF + depends on OF && COMMON_CLK help Say Y here to include support for the I2C adapter in Rockchip RK3xxx SoCs.
Signature · 1 line
1.9.1
Hello Max,
Quoted 3 lines · Max Schwarz
Now that we are using the clk notifier framework we get compile errors without
COMMON_CLK. But the driver fails to probe withoutCOMMON_CLKanyways, so just add that as aKconfigdependency.
Hmm, I wonder how a kernel that fails to compile can even start probing ... :-)
Anyhow, it would be nice to quote the compiler error you fix here and point out the patch that failed to add the needed dependency.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Wolfram Sang
AppliedQuoted 11 lines · Uwe Kleine-König
Hello Max,
Quoted 3 lines · Max Schwarz
Now that we are using the clk notifier framework we get compile errors without
COMMON_CLK. But the driver fails to probe withoutCOMMON_CLKanyways, so just add that as aKconfigdependency.Hmm, I wonder how a kernel that fails to compile can even start probing ... :-)
Anyhow, it would be nice to quote the compiler error you fix here and point out the patch that failed to add the needed dependency.
Yes, that would be perfect. But for fixing the breakage in linux-next we created, this is good enough for me.
Applied to for-next, thanks!
Hey Wolfram,
Quoted 10 lines · Wolfram Sang
Quoted 9 lines · Uwe Kleine-König
Hello Max,
Quoted 3 lines · Max Schwarz
Now that we are using the clk notifier framework we get compile errors without
COMMON_CLK. But the driver fails to probe withoutCOMMON_CLKanyways, so just add that as aKconfigdependency.Hmm, I wonder how a kernel that fails to compile can even start probing ... :-)
Quoted 7 lines
Quoted 2 lines
Anyhow, it would be nice to quote the compiler error you fix here and point out the patch that failed to add the needed dependency.
Yes, that would be perfect. But for fixing the breakage in linux-next we created, this is good enough for me.
Applied to for-next, thanks!
Just for me to learn: is your for-next stable once pushed?
As you didn't push out yet, it's
party on,
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 3 lines
Quoted 2 lines
Applied to for-next, thanks!
Just for me to learn: is your for-next stable once pushed?
Nope, I push manually when I feel comfortable. That might change, though.
Quoted 3 lines
As you didn't push out yet, it's
Fixes 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")
Actually, it is 249051f49907. I rebased my internal i2c/for-3.19 tree to fix an authorship and merged that into i2c/for-next. For those reasons, my current policy is to use "Fixes:" only for commits which hit the linus-tree. I probably shouldn't do such things, but as long as I was working on my own, this worked pretty well ;)
Quoted 9 lines · Wolfram Sang
Quoted 3 lines
Quoted 2 lines
Applied to for-next, thanks!
Just for me to learn: is your for-next stable once pushed?
Nope, I push manually when I feel comfortable. That might change, though.
Quoted 2 lines
As you didn't push out yet, it's
Quoted 7 lines
Quoted 1 line
Fixes 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")Actually, it is
249051f49907. I rebased my internal i2c/for-3.19 tree to fix an authorship and merged that into i2c/for-next. For those reasons, my current policy is to use "Fixes:" only for commits which hit the linus-tree. I probably shouldn't do such things, but as long as I was working on my own, this worked pretty well ;)
If it's not stable you can even squash in the fix. In this case the commit log drill was superfluous for this commit, but (hopefully) still useful for the future.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 3 lines
commit log drill was superfluous for this commit, but (hopefully) still useful for the future.
I think so.