irq: Invalid fwnode type (2) for irqdomain
Dear Linux folks,
On a Lenovo X60t with coreboot based firmware testing the latest master branch from Linus, the message below is new, and isn’t there with Linux 4.12.
``` irq: Invalid fwnode type (2) for irqdomain ```
git blame kernel/irq/irqdomain.c shows, the message is added in commit d59f661 (genirq: Allow fwnode to carry name information only).
The commit message describes the warning.
Quoted 3 lines
Warn if an invalid node is supplied and treat it like no node. This happens e.g. with i2 devices on x86 which hand in an ACPI type node which has no interface for retrieving the name.
How can I find out, how the ACPI/ASL has to be fixed?
Kind regards,
Paul
Quoted 11 lines · Paul Menzel
On a Lenovo X60t with coreboot based firmware testing the latest master branch from Linus, the message below is new, and isn’t there with Linux 4.12.
``` irq: Invalid fwnode type (2) for irqdomain ```
git blame kernel/irq/irqdomain.cshows, the message is added in commit d59f661 (genirq: Allow fwnode to carry name information only).
Quoted 7 lines
The commit message describes the warning.
Quoted 3 lines
Warn if an invalid node is supplied and treat it like no node. This happens e.g. with i2 devices on x86 which hand in an ACPI type node which has no interface for retrieving the name.
How can I find out, how the ACPI/ASL has to be fixed?
It's not an ACPI/ASL issue. Sorry, if the description and error message is not clear. That's a kernel internal issue because we have no interface yet to retrieve the required information. I'll have a look later today.
Thanks,
tglx
Quoted 18 lines · Thomas Gleixner
Quoted 17 lines · Paul Menzel
On a Lenovo X60t with coreboot based firmware testing the latest master branch from Linus, the message below is new, and isn’t there with Linux 4.12.
``` irq: Invalid fwnode type (2) for irqdomain ```
git blame kernel/irq/irqdomain.cshows, the message is added in commit d59f661 (genirq: Allow fwnode to carry name information only).The commit message describes the warning.
Quoted 3 lines
Warn if an invalid node is supplied and treat it like no node. This happens e.g. with i2 devices on x86 which hand in an ACPI type node which has no interface for retrieving the name.
Quoted 5 lines
Quoted 1 line
How can I find out, how the ACPI/ASL has to be fixed?
It's not an ACPI/ASL issue. Sorry, if the description and error message is not clear. That's a kernel internal issue because we have no interface yet to retrieve the required information. I'll have a look later today.
I've been reported an issue that is somewhat related to this, Any chance you could give this[1] a go? I have no way to test it...
Thanks,
M.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/fixes-4.13
Signature · 1 line
Jazz is not dead. It just smells funny...
Dear Marc, dear John,
Am Donnerstag, den 06.07.2017, 15:21 +0100 schrieb Marc Zyngier:
Quoted 26 lines · Thomas Gleixner
Quoted 25 lines · Paul Menzel
Quoted 23 lines
On a Lenovo X60t with coreboot based firmware testing the latest master
branch from Linus, the message below is new, and isn’t there with Linux
4.12.``` irq: Invalid fwnode type (2) for irqdomain ```
git blame kernel/irq/irqdomain.cshows, the message is added in commit d59f661 (genirq: Allow fwnode to carry name information only).The commit message describes the warning.
Quoted 5 lines
Warn if an invalid node is supplied and treat it like no node. This
happens e.g. with i2 devices on x86 which hand in an ACPI type node
which has no interface for retrieving the name.How can I find out, how the ACPI/ASL has to be fixed?
Quoted 8 lines
Quoted 5 lines
It's not an ACPI/ASL issue. Sorry, if the description and error message is
not clear. That's a kernel internal issue because we have no interface yet
to retrieve the required information. I'll have a look later today.I've been reported an issue that is somewhat related to this, Any chance you could give this[1] a go? I have no way to test it...
The commit below indeed made the warning go away.
Quoted 18 lines
commit
6bf31c05f2a967e5351a3050ef51c18c8c9ee291
Author: Marc Zyngier <[email protected]>
Date: Thu Jul 6 14:51:31 2017 +0100irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers
A number of irqchip implementations are (ab)using the irqdomain allocator by passing a fwnode that is neither aFWNODE_OFor aFWNODE_IRQCHIP.
This is pretty bad, but it also feels pretty crap to force these drivers to allocate their ownirqchip_fwidwhen they already have a proper fwnode.
Instead, let's teach the irqdomain allocator about ACPI device nodes, and add some lovely name generation code... Tested on an arm64 D05 system.
Quoted 2 lines
Reported-by John Garry <[email protected]>Signed-off-by Marc Zyngier <[email protected]>
I wonder if a warning/debug messages could and should still be shown, if a fwnode is neither a FWNODE_OF or a FWNODE_IRQCHIP.
Kind regards,
Paul
On Sat, Jul 08 2017 at 9:28:17 am BST, Paul Menzel <[email protected]> wrote:
Hi Paul,
Quoted 26 lines
Quoted 2 lines
I've been reported an issue that is somewhat related to this, Any chance you could give this[1] a go? I have no way to test it...
The commit below indeed made the warning go away.
Quoted 18 lines
commit
6bf31c05f2a967e5351a3050ef51c18c8c9ee291
Author: Marc Zyngier <[email protected]>
Date: Thu Jul 6 14:51:31 2017 +0100irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers
A number of irqchip implementations are (ab)using the irqdomain allocator by passing a fwnode that is neither aFWNODE_OFor aFWNODE_IRQCHIP.
This is pretty bad, but it also feels pretty crap to force these drivers to allocate their ownirqchip_fwidwhen they already have a proper fwnode.
Instead, let's teach the irqdomain allocator about ACPI device nodes, and add some lovely name generation code... Tested on an arm64 D05 system.Quoted 2 lines
Reported-by John Garry <[email protected]>Signed-off-by Marc Zyngier <[email protected]>
Quoted 2 lines
I wonder if a warning/debug messages could and should still be shown, if a fwnode is neither a
FWNODE_OFor aFWNODE_IRQCHIP.
With this patch, the code covers FWNODE_OF, FWNODE_IRQCHIP and FWNODE_ACPI (the latter being the case you and John uncovered). Should we get any other fwnode_type value, the irqdomain code will still warn the user that this is not an object type we're ready to accept.
Thanks again for the report and the testing.
M.
Signature · 1 line
Jazz is not dead. It just smells funny.