Skip to contentSkip to conversation

librcf: support build on mips/mipsel

PATCH In review [email protected] 2 participants 3 messages Jul 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 librcf: support build on mips/mipsel

From: Ming Liu <[email protected]>

This fixes following errors when building on mips/mipsel:
...
src/RCF/ByteOrdering.cpp:115:13: error: 'MachineByteOrder' was not declared in this scope

         if (MachineByteOrder != NetworkByteOrder)
             ^~~~~~~~~~~~~~~~
src/RCF/ByteOrdering.cpp:123:13: error: 'MachineByteOrder' was not declared in this scope
         if (MachineByteOrder != NetworkByteOrder)

src/RCF/ByteOrdering.cpp:131:16: error: 'MachineByteOrder' was not declared in this scope

         return MachineByteOrder == NetworkByteOrder;

src/RCF/ByteOrdering.cpp:136:16: error: 'MachineByteOrder' was not declared in this scope

         return MachineByteOrder == LittleEndian;

...

---
 .../librcf/librcf/0001-mips-mipsel-support.patch   | 34 ++++++++++++++++++++++
 meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb  |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/librcf/librcf/0001-mips-mipsel-support.patch
meta-oe/recipes-devtools/librcf/librcf/0001-mips-mipsel-support.patch new file +34 -0
new file mode 100644
index 0000000..6d873c4
@@ -0,0 +1,34 @@
+From a0e6a851a7504150e5191b206b8885fa17ce9ab3 Mon Sep 17 00:00:00 2001
+From: Ming Liu <[email protected]>
+Date: Fri, 7 Jul 2017 10:46:45 +0200
+Subject: [PATCH] Support build for mips/mipsel
+
+Upstream-Status: Pending
+
+Signed-off-by: Ming Liu <[email protected]>
+---
+ src/RCF/ByteOrdering.cpp | 8 ++++++++
+ 1 file changed, 8 insertions(+)
+
+diff --git a/src/RCF/ByteOrdering.cpp b/src/RCF/ByteOrdering.cpp
+index 5f3d937..ab99967 100755
+--- a/src/RCF/ByteOrdering.cpp
++++ b/src/RCF/ByteOrdering.cpp
+@@ -64,6 +64,14 @@ namespace RCF {
+ 
+     const ByteOrder MachineByteOrder = LittleEndian;
+ 
++#elif defined(_MIPSEL) || defined(__MIPSEL) || defined(__MIPSEL__)
++
++    const ByteOrder MachineByteOrder = LittleEndian;
++
++#elif defined(_mips) || defined(__mips) || defined(__mips__)
++
++    const ByteOrder MachineByteOrder = BigEndian;
++
+ #elif defined(__bfin__)
+ 
+     const ByteOrder MachineByteOrder = LittleEndian;
+-- 
+2.7.4
+
meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb +1 -0
index 4c9683a..4dac10e 100644
@@ -14,6 +14,7 @@ SRC_URI = "http://www.deltavsoft.com/downloads/RCF-${PV}.tar.gz \
            file://0001-Add-CMake-build-files.patch \
            file://aarch64-support.patch \
            file://0001-ClientStub.hpp-fix-a-clang-compiling-issue.patch \
+           file://0001-mips-mipsel-support.patch \
           "
 
 SRC_URI[md5sum] = "7ecb3c73f7eb66dba8790b659374f690"
Signature · 1 line
2.7.4
#1 lore raw
Quoted 10 lines · On Fri, Jul 7, 2017 at 3:27 AM, <[email protected]> wrote:

From: Ming Liu <[email protected]>

This fixes following errors when building on mips/mipsel:
...
src/RCF/ByteOrdering.cpp:115:13: error: 'MachineByteOrder' was not declared in this scope

         if (MachineByteOrder != NetworkByteOrder)
             ^~~~~~~~~~~~~~~~
src/RCF/ByteOrdering.cpp:123:13: error: 'MachineByteOrder' was not declared in this scope
         if (MachineByteOrder != NetworkByteOrder)
Quoted 6 lines

src/RCF/ByteOrdering.cpp:131:16: error: 'MachineByteOrder' was not declared in this scope

         return MachineByteOrder == NetworkByteOrder;

src/RCF/ByteOrdering.cpp:136:16: error: 'MachineByteOrder' was not declared in this scope

         return MachineByteOrder == LittleEndian;

...

already fixed by

http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=5ed1dba5f8fdca6c78bf61128aedd0426eb98424

Quoted 68 lines
---
 .../librcf/librcf/0001-mips-mipsel-support.patch   | 34 ++++++++++++++++++++++
 meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb  |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/librcf/librcf/0001-mips-mipsel-support.patch
meta-oe/recipes-devtools/librcf/librcf/0001-mips-mipsel-support.patch new file +34 -0
new file mode 100644
index 0000000..6d873c4
@@ -0,0 +1,34 @@
+From a0e6a851a7504150e5191b206b8885fa17ce9ab3 Mon Sep 17 00:00:00 2001
+From: Ming Liu <[email protected]>
+Date: Fri, 7 Jul 2017 10:46:45 +0200
+Subject: [PATCH] Support build for mips/mipsel
+
+Upstream-Status: Pending
+
+Signed-off-by: Ming Liu <[email protected]>
+---
+ src/RCF/ByteOrdering.cpp | 8 ++++++++
+ 1 file changed, 8 insertions(+)
+
+diff --git a/src/RCF/ByteOrdering.cpp b/src/RCF/ByteOrdering.cpp
+index 5f3d937..ab99967 100755
+--- a/src/RCF/ByteOrdering.cpp
++++ b/src/RCF/ByteOrdering.cpp
+@@ -64,6 +64,14 @@ namespace RCF {
+
+     const ByteOrder MachineByteOrder = LittleEndian;
+
++#elif defined(_MIPSEL) || defined(__MIPSEL) || defined(__MIPSEL__)
++
++    const ByteOrder MachineByteOrder = LittleEndian;
++
++#elif defined(_mips) || defined(__mips) || defined(__mips__)
++
++    const ByteOrder MachineByteOrder = BigEndian;
++
+ #elif defined(__bfin__)
+
+     const ByteOrder MachineByteOrder = LittleEndian;
+--
+2.7.4
+
meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb +1 -1
index 4c9683a..4dac10e 100644
@@ -14,6 +14,7 @@ SRC_URI = "http://www.deltavsoft.com/downloads/RCF-${PV}.tar.gz \
            file://0001-Add-CMake-build-files.patch \
            file://aarch64-support.patch \
            file://0001-ClientStub.hpp-fix-a-clang-compiling-issue.patch \
+           file://0001-mips-mipsel-support.patch \
           "
 
 SRC_URI[md5sum] = "7ecb3c73f7eb66dba8790b659374f690"
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#2 lore raw

Arha, please ignore my patch then. Thanks.

//Ming Liu

2017-07-07 15:44 GMT+02:00 Khem Raj <[email protected]>:

Quoted 104 lines · On Fri, Jul 7, 2017 at 3:27 AM, <[email protected]> wrote:
Quoted 5 lines

From: Ming Liu <[email protected]>

This fixes following errors when building on mips/mipsel:
...
src/RCF/ByteOrdering.cpp:115:13: error: 'MachineByteOrder' was not

declared in this scope

Quoted 3 lines
         if (MachineByteOrder != NetworkByteOrder)
             ^~~~~~~~~~~~~~~~

src/RCF/ByteOrdering.cpp:123:13: error: 'MachineByteOrder' was not

declared in this scope

Quoted 3 lines
         if (MachineByteOrder != NetworkByteOrder)

src/RCF/ByteOrdering.cpp:131:16: error: 'MachineByteOrder' was not

declared in this scope

Quoted 3 lines
         return MachineByteOrder == NetworkByteOrder;

src/RCF/ByteOrdering.cpp:136:16: error: 'MachineByteOrder' was not

declared in this scope

Quoted 2 lines
         return MachineByteOrder == LittleEndian;

...

already fixed by

http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=
5ed1dba5f8fdca6c78bf61128aedd0426eb98424

Quoted 4 lines
---
 .../librcf/librcf/0001-mips-mipsel-support.patch   | 34

++++++++++++++++++++++

Quoted 3 lines
 meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb  |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/librcf/librcf/0001-mips-

mipsel-support.patch

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta-oe/recipes-devtools/librcf/librcf/0001-mips-mipsel-support.patch

meta-oe/recipes-devtools/librcf/librcf/0001-mips-

Quoted 4 lines

new file mode 100644
index 0000000..6d873c4

meta-oe/recipes-devtools/librcf/librcf/0001-mips- new file +0 -0

mipsel-support.patch

Review

Quoted 36 lines
meta-oe/recipes-devtools/librcf/librcf/0001-mips- new file +34 -0
@@ -0,0 +1,34 @@
+From a0e6a851a7504150e5191b206b8885fa17ce9ab3 Mon Sep 17 00:00:00 2001
+From: Ming Liu <[email protected]>
+Date: Fri, 7 Jul 2017 10:46:45 +0200
+Subject: [PATCH] Support build for mips/mipsel
+
+Upstream-Status: Pending
+
+Signed-off-by: Ming Liu <[email protected]>
+---
+ src/RCF/ByteOrdering.cpp | 8 ++++++++
+ 1 file changed, 8 insertions(+)
+
+diff --git a/src/RCF/ByteOrdering.cpp b/src/RCF/ByteOrdering.cpp
+index 5f3d937..ab99967 100755
+--- a/src/RCF/ByteOrdering.cpp
++++ b/src/RCF/ByteOrdering.cpp
+@@ -64,6 +64,14 @@ namespace RCF {
+
+     const ByteOrder MachineByteOrder = LittleEndian;
+
++#elif defined(_MIPSEL) || defined(__MIPSEL) || defined(__MIPSEL__)
++
++    const ByteOrder MachineByteOrder = LittleEndian;
++
++#elif defined(_mips) || defined(__mips) || defined(__mips__)
++
++    const ByteOrder MachineByteOrder = BigEndian;
++
+ #elif defined(__bfin__)
+
+     const ByteOrder MachineByteOrder = LittleEndian;
+--
+2.7.4
+
(quoted diff) +0 -0

b/meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb

meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb SRC_URI = "http://www.deltavsoft.com/

Quoted 4 lines

index 4c9683a..4dac10e 100644

meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb +0 -0
@@ -14,6 +14,7 @@ SRC_URI = "http://www.deltavsoft.com/

downloads/RCF-${PV}.tar.gz \

meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb SRC_URI = "http://www.deltavsoft.com/downloads/RCF-${PV}.tar.gz \

Quoted 3 lines
meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb +0 -0
            file://0001-Add-CMake-build-files.patch \
            file://aarch64-support.patch \
            file://0001-ClientStub.hpp-fix-a-clang-compiling-issue.patch

\

Quoted 12 lines
meta-oe/recipes-devtools/librcf/librcf_2.2.0.0.bb +1 -1
+           file://0001-mips-mipsel-support.patch \
           "
 
 SRC_URI[md5sum] = "7ecb3c73f7eb66dba8790b659374f690"
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel