Skip to contentSkip to conversation

ASoC: rt274: add rt274 codec driver

PATCH In review Bard Liao 2 participants 4 messages Jul 14, 2017 – Jul 19, 2017 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

Bard Liao

author
#0 lore raw

PATCH 1/1 ASoC: rt274: add rt274 codec driver

RT274 is a HD-A/SOC dual mode codec. This is the initial codec driver of SOC mode.

---
 Documentation/devicetree/bindings/sound/rt274.txt |   33 +
 sound/soc/codecs/Kconfig                          |    7 +
 sound/soc/codecs/Makefile                         |    2 +
 sound/soc/codecs/rt274.c                          | 1228 +++++++++++++++++++++
 sound/soc/codecs/rt274.h                          |  217 ++++
 5 files changed, 1487 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/rt274.txt
 create mode 100644 sound/soc/codecs/rt274.c
 create mode 100644 sound/soc/codecs/rt274.h
Documentation/devicetree/bindings/sound/rt274.txt new file +33 -0
new file mode 100644
index 0000000..e9a6178
@@ -0,0 +1,33 @@
+RT274 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : "realtek,rt274".
+
+- reg : The I2C address of the device.
+
+Optional properties:
+
+- interrupts : The CODEC's interrupt output.
+
+
+Pins on the device (for linking into audio routes) for RT274:
+
+  * DMIC1 Pin
+  * DMIC2 Pin
+  * MIC
+  * LINE1
+  * LINE2
+  * HPO Pin
+  * SPDIF
+  * LINE3
+
+Example:
+
+codec: rt274@1c {
+	compatible = "realtek,rt274";
+	reg = <0x1c>;
+	interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
+};
sound/soc/codecs/Kconfig +7 -0
index 6c78b0b..024ddc9 100644
@@ -114,6 +114,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_PCM5102A
 	select SND_SOC_PCM512x_I2C if I2C
 	select SND_SOC_PCM512x_SPI if SPI_MASTER
+	select SND_SOC_RT274 if I2C
 	select SND_SOC_RT286 if I2C
 	select SND_SOC_RT298 if I2C
 	select SND_SOC_RT5514 if I2C
@@ -716,11 +717,17 @@ config SND_SOC_RL6231
 
 config SND_SOC_RL6347A
 	tristate
+	default y if SND_SOC_RT274=y
 	default y if SND_SOC_RT286=y
 	default y if SND_SOC_RT298=y
+	default m if SND_SOC_RT274=m
 	default m if SND_SOC_RT286=m
 	default m if SND_SOC_RT298=m
 
+config SND_SOC_RT274
+	tristate
+	depends on I2C
+
 config SND_SOC_RT286
 	tristate
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index 1755a54..a8a4b07 100644
@@ -113,6 +113,7 @@ snd-soc-pcm512x-i2c-objs := pcm512x-i2c.o
 snd-soc-pcm512x-spi-objs := pcm512x-spi.o
 snd-soc-rl6231-objs := rl6231.o
 snd-soc-rl6347a-objs := rl6347a.o
+snd-soc-rt274-objs := rt274.o
 snd-soc-rt286-objs := rt286.o
 snd-soc-rt298-objs := rt298.o
 snd-soc-rt5514-objs := rt5514.o
@@ -349,6 +350,7 @@ obj-$(CONFIG_SND_SOC_PCM512x_I2C)	+= snd-soc-pcm512x-i2c.o
 obj-$(CONFIG_SND_SOC_PCM512x_SPI)	+= snd-soc-pcm512x-spi.o
 obj-$(CONFIG_SND_SOC_RL6231)	+= snd-soc-rl6231.o
 obj-$(CONFIG_SND_SOC_RL6347A)	+= snd-soc-rl6347a.o
+obj-$(CONFIG_SND_SOC_RT274)	+= snd-soc-rt274.o
 obj-$(CONFIG_SND_SOC_RT286)	+= snd-soc-rt286.o
 obj-$(CONFIG_SND_SOC_RT298)	+= snd-soc-rt298.o
 obj-$(CONFIG_SND_SOC_RT5514)	+= snd-soc-rt5514.o
sound/soc/codecs/rt274.c new file +1228 -0

1,228 lines not on this page · raw message

sound/soc/codecs/rt274.h new file +217 -0

217 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 2 lines · Bard Liao

RT274 is a HD-A/SOC dual mode codec. This is the initial codec driver of SOC mode.

This looks good, I've applied it. There was one C++ comment deep in there which I didn't want to trawl through and find to quote but can you please send a followup patch making it a regular C comment.

A message that is not in the archive (sent off-list or not yet received): ABFD875FF5FB574BA706497D987D48D70268F0ED@RTITMBSV02.realtek.com.tw

maintainer
#3 lore raw
Quoted 2 lines · Bard Liao

I have sent a patch for it. But I was wondering why checkpatch.pl can't find the style issue?

No idea, sorry.

maintainer
#4 lore raw

Applied "ASoC: rt274: add rt274 codec driver" to the asoc tree

In reply to Bard Liao

The patch

ASoC: rt274: add rt274 codec driver

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From c7e79b2b2d2d7c13c6162ed8672357f4ad0fd8f5 Mon Sep 17 00:00:00 2001

From: Bard Liao <[email protected]>
Date: Fri, 14 Jul 2017 14:25:52 +0800
Subject: [PATCH] ASoC: rt274: add rt274 codec driver

RT274 is a HD-A/SOC dual mode codec. This is the initial codec driver of SOC mode.

---
 Documentation/devicetree/bindings/sound/rt274.txt |   33 +
 sound/soc/codecs/Kconfig                          |    7 +
 sound/soc/codecs/Makefile                         |    2 +
 sound/soc/codecs/rt274.c                          | 1228 +++++++++++++++++++++
 sound/soc/codecs/rt274.h                          |  217 ++++
 5 files changed, 1487 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/rt274.txt
 create mode 100644 sound/soc/codecs/rt274.c
 create mode 100644 sound/soc/codecs/rt274.h
Documentation/devicetree/bindings/sound/rt274.txt new file +33 -0
new file mode 100644
index 000000000000..e9a6178c78cf
@@ -0,0 +1,33 @@
+RT274 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : "realtek,rt274".
+
+- reg : The I2C address of the device.
+
+Optional properties:
+
+- interrupts : The CODEC's interrupt output.
+
+
+Pins on the device (for linking into audio routes) for RT274:
+
+  * DMIC1 Pin
+  * DMIC2 Pin
+  * MIC
+  * LINE1
+  * LINE2
+  * HPO Pin
+  * SPDIF
+  * LINE3
+
+Example:
+
+codec: rt274@1c {
+	compatible = "realtek,rt274";
+	reg = <0x1c>;
+	interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
+};
sound/soc/codecs/Kconfig +7 -0
index 6c78b0b49b81..024ddc9938ed 100644
@@ -114,6 +114,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_PCM5102A
 	select SND_SOC_PCM512x_I2C if I2C
 	select SND_SOC_PCM512x_SPI if SPI_MASTER
+	select SND_SOC_RT274 if I2C
 	select SND_SOC_RT286 if I2C
 	select SND_SOC_RT298 if I2C
 	select SND_SOC_RT5514 if I2C
@@ -716,11 +717,17 @@ config SND_SOC_RL6231
 
 config SND_SOC_RL6347A
 	tristate
+	default y if SND_SOC_RT274=y
 	default y if SND_SOC_RT286=y
 	default y if SND_SOC_RT298=y
+	default m if SND_SOC_RT274=m
 	default m if SND_SOC_RT286=m
 	default m if SND_SOC_RT298=m
 
+config SND_SOC_RT274
+	tristate
+	depends on I2C
+
 config SND_SOC_RT286
 	tristate
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index 1755a54e3dc9..a8a4b0797f46 100644
@@ -113,6 +113,7 @@ snd-soc-pcm512x-i2c-objs := pcm512x-i2c.o
 snd-soc-pcm512x-spi-objs := pcm512x-spi.o
 snd-soc-rl6231-objs := rl6231.o
 snd-soc-rl6347a-objs := rl6347a.o
+snd-soc-rt274-objs := rt274.o
 snd-soc-rt286-objs := rt286.o
 snd-soc-rt298-objs := rt298.o
 snd-soc-rt5514-objs := rt5514.o
@@ -349,6 +350,7 @@ obj-$(CONFIG_SND_SOC_PCM512x_I2C)	+= snd-soc-pcm512x-i2c.o
 obj-$(CONFIG_SND_SOC_PCM512x_SPI)	+= snd-soc-pcm512x-spi.o
 obj-$(CONFIG_SND_SOC_RL6231)	+= snd-soc-rl6231.o
 obj-$(CONFIG_SND_SOC_RL6347A)	+= snd-soc-rl6347a.o
+obj-$(CONFIG_SND_SOC_RT274)	+= snd-soc-rt274.o
 obj-$(CONFIG_SND_SOC_RT286)	+= snd-soc-rt286.o
 obj-$(CONFIG_SND_SOC_RT298)	+= snd-soc-rt298.o
 obj-$(CONFIG_SND_SOC_RT5514)	+= snd-soc-rt5514.o
sound/soc/codecs/rt274.c new file +1228 -0

1,228 lines not on this page · raw message

sound/soc/codecs/rt274.h new file +217 -0

217 lines not on this page · raw message

Signature · 1 line
2.13.2