Skip to contentSkip to conversation

Advsync: fix typos

PATCH In review Junchang Wang 2 participants 3 messages Jul 15, 2017

lore
Share & tools
lore

Junchang Wang

author
#0 lore raw

PATCH 1/1 Advsync: fix typos

Hi Paul,

I have read through Chapter Advance Synchronization, and following are two typos. Please take a look. Thanks for this excellent book!

Signed-off-by Junchang Wang <[email protected]>
---
 advsync/memorybarriers.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
advsync/memorybarriers.tex +2 -2
index c9c975c..009dc6e 100644
@@ -950,7 +950,7 @@ thereby forcing the required ordering on all platforms.
 \label{fig:advsync:S Address-Dependency Litmus Test}
 \end{figure}
 
-But suppose that the dependent operation is a write rather than
+But what happens if the dependent operation is a write rather than
 a read, for example, in the \emph{S}
 litmus test~\cite{JadeAlglave2011ppcmem} shown in
 Figure~\ref{fig:advsync:S Address-Dependency Litmus Test}?

@@ -2511,7 +2511,7 @@ Failure to follow this rule can have serious side effects:
 	In theory, yes, you could load an integer, perhaps to use
 	it as an array index.
 	In practice, the compiler knows too much about integers,
-	and thus has way too many opportunities to break your
+	and thus has too many opportunities to break your
 	dependency chain.
 \end{enumerate}
Signature · 1 line
2.7.4
#1 lore raw

Hi Jason,

Quoted 24 lines · Junchang Wang

Hi Paul,

I have read through Chapter Advance Synchronization, and following are two typos. Please take a look. Thanks for this excellent book!

Signed-off-by Junchang Wang <[email protected]>
---
 advsync/memorybarriers.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
advsync/memorybarriers.tex +1 -1
index c9c975c..009dc6e 100644
@@ -950,7 +950,7 @@ thereby forcing the required ordering on all platforms.
 \label{fig:advsync:S Address-Dependency Litmus Test}
 \end{figure}
 
-But suppose that the dependent operation is a write rather than
+But what happens if the dependent operation is a write rather than
 a read, for example, in the \emph{S}
 litmus test~\cite{JadeAlglave2011ppcmem} shown in
 Figure~\ref{fig:advsync:S Address-Dependency Litmus Test}?

advsync/memorybarriers.tex Failure to follow this rule can have serious side effects: · line 2514

Quoted 5 lines
advsync/memorybarriers.tex +1 -1
@@ -2511,7 +2511,7 @@ Failure to follow this rule can have serious side effects:
 	In theory, yes, you could load an integer, perhaps to use
 	it as an array index.
 	In practice, the compiler knows too much about integers,
-	and thus has way too many opportunities to break your
+	and thus has too many opportunities to break your

This "way" is an adverb for emphasizing. It might sound colloquial but it's the tone in perfbook. So I would NAK this hunk.

Also, the format of this message would result in your greetings being included in the commit log if it were applied as is.
It would be better if you put the greetings between "---" and diff stat.

For the 1st hunk, I would suggest a commit title something like:

advsync: Rephrase question as such

Can you try a respin with the following tag?

Suggested-by Akira Yokosawa <[email protected]>

Thanks, Akira

Quoted 4 lines
advsync/memorybarriers.tex +0 -0
 	dependency chain.
 \end{enumerate}
author
#2 lore raw

Hi Akira,

Quoted 21 lines · Akira Yokosawa

Hi Jason,

Quoted 18 lines · Junchang Wang

Hi Paul,

I have read through Chapter Advance Synchronization, and following are two typos. Please take a look. Thanks for this excellent book!

Signed-off-by Junchang Wang <[email protected]>
---
 advsync/memorybarriers.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
advsync/memorybarriers.tex +0 -0
index c9c975c..009dc6e 100644
@@ -950,7 +950,7 @@ thereby forcing the required ordering on all platforms.
 \label{fig:advsync:S Address-Dependency Litmus Test}
 \end{figure}
Quoted 15 lines

advsync/memorybarriers.tex Failure to follow this rule can have serious side effects: · line 2514

Quoted 11 lines
advsync/memorybarriers.tex +2 -2
-But suppose that the dependent operation is a write rather than
+But what happens if the dependent operation is a write rather than
 a read, for example, in the \emph{S}
 litmus test~\cite{JadeAlglave2011ppcmem} shown in
 Figure~\ref{fig:advsync:S Address-Dependency Litmus Test}?

@@ -2511,7 +2511,7 @@ Failure to follow this rule can have serious side effects:
      In theory, yes, you could load an integer, perhaps to use
      it as an array index.
      In practice, the compiler knows too much about integers,
-     and thus has way too many opportunities to break your
+     and thus has too many opportunities to break your

This "way" is an adverb for emphasizing. It might sound colloquial but it's the tone in perfbook. So I would NAK this hunk.

Thanks a lot for the explanation!

Quoted 10 lines

Also, the format of this message would result in your greetings being included in the commit log if it were applied as is.
It would be better if you put the greetings between "---" and diff stat.

For the 1st hunk, I would suggest a commit title something like:

advsync: Rephrase question as such

Can you try a respin with the following tag?

Sure. I can resend a new patch soon.

Thanks,
--Jason

Quoted 9 lines
Suggested-by Akira Yokosawa <[email protected]>

Thanks, Akira

Quoted 4 lines
advsync/memorybarriers.tex +0 -0
      dependency chain.
 \end{enumerate}