Skip to contentSkip to conversation

Patch "rocker: move dereference before free" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jul 17, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

rocker: move dereference before free

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rocker-move-dereference-before-free.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jul 17 18:47:09 CEST 2017

From: Dan Carpenter <[email protected]>
Date: Wed, 28 Jun 2017 14:44:21 +0300
Subject: rocker: move dereference before free

From: Dan Carpenter <[email protected]>

[ Upstream commit acb4b7df48b539cb391287921de57e4e5fae3460 ]

My static checker complains that ofdpa_neigh_del() can sometimes free
"found". It just makes sense to use it first before deleting it.

Fixes ecf244f753e0 ("rocker: fix maybe-uninitialized warning")
---
 drivers/net/ethernet/rocker/rocker_ofdpa.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/rocker/rocker_ofdpa.c +1 -1
@@ -1505,8 +1505,8 @@ static int ofdpa_port_ipv4_nh(struct ofd
 		*index = entry->index;
 		resolved = false;
 	} else if (removing) {
-		ofdpa_neigh_del(trans, found);
 		*index = found->index;
+		ofdpa_neigh_del(trans, found);
 	} else if (updating) {
 		ofdpa_neigh_update(found, trans, NULL, false);
 		resolved = !is_zero_ether_addr(found->eth_dst);

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/rocker-move-dereference-before-free.patch