Skip to contentSkip to conversation

Patch "rds: tcp: use sock_create_lite() to create the accept socket" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 18, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

rds: tcp: use sock_create_lite() to create the accept socket

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rds-tcp-use-sock_create_lite-to-create-the-accept-socket.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 0933a578cd55b02dc80f219dc8f2efb17ec61c9a Mon Sep 17 00:00:00 2001

From: Sowmini Varadhan <[email protected]>
Date: Thu, 6 Jul 2017 08:15:06 -0700
Subject: rds: tcp: use sock_create_lite() to create the accept socket

From: Sowmini Varadhan <[email protected]>

commit 0933a578cd55b02dc80f219dc8f2efb17ec61c9a upstream.

There are two problems with calling sock_create_kern() from rds_tcp_accept_one()
1. it sets up a new_sock->sk that is wasteful, because this ->sk is going to get replaced by inet_accept() in the subsequent ->accept()
2. The new_sock->sk is a leaked reference in sock_graft() which expects to find a null parent->sk

Avoid these problems by calling sock_create_lite().

---
 net/rds/tcp_listen.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/rds/tcp_listen.c +1 -1
@@ -78,7 +78,7 @@ int rds_tcp_accept_one(struct socket *so
 	struct inet_sock *inet;
 	struct rds_tcp_connection *rs_tcp;
 
-	ret = sock_create_kern(sock_net(sock->sk), sock->sk->sk_family,
+	ret = sock_create_lite(sock->sk->sk_family,
 			       sock->sk->sk_type, sock->sk->sk_protocol,
 			       &new_sock);
 	if (ret)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/rds-tcp-use-sock_create_lite-to-create-the-accept-socket.patch