Skip to contentSkip to conversation

MAINTAINERS: Fix multiple line section header for XGENE

PATCH In review Joe Perches 2 participants 3 messages Jul 21, 2017

lore
Share & tools
lore

Joe Perches

author
#0 lore raw

PATCH 1/1 MAINTAINERS: Fix multiple line section header for XGENE

Section headers should be single line.

Fix it.

Signed-off-by Joe Perches <[email protected]>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
index 542f7dee98f0..0b59df2498e9 100644
@@ -5029,8 +5029,7 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/edac/skx_edac.c
 
-EDAC-XGENE
-APPLIED MICRO (APM) X-GENE SOC EDAC
+EDAC-XGENE-APPLIED MICRO (APM) X-GENE SOC EDAC
 M:     Loc Ho <[email protected]>
 S:     Supported
 F:     drivers/edac/xgene_edac.c
#1 lore raw

Hi,

Quoted 3 lines · Joe Perches

Section headers should be single line.

Fix it.

Can we drop the "Fix it."

Quoted 11 lines
Signed-off-by Joe Perches <[email protected]>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index 542f7dee98f0..0b59df2498e9 100644

MAINTAINERS L: [email protected] · line 5032

Quoted 6 lines
MAINTAINERS +1 -2
@@ -5029,8 +5029,7 @@ L:        [email protected]
 S:     Maintained
 F:     drivers/edac/skx_edac.c
 
-EDAC-XGENE
-APPLIED MICRO (APM) X-GENE SOC EDAC
+EDAC-XGENE-APPLIED MICRO (APM) X-GENE SOC EDAC

To be consistent with other, how about just:

EDAC-XGENE (drop the Applied micro ... line)

MAINTAINERS L: [email protected] · line 5035

Quoted 3 lines
MAINTAINERS +0 -0
 M:     Loc Ho <[email protected]>
 S:     Supported
 F:     drivers/edac/xgene_edac.c

-Loc

author
#2 lore raw
Quoted 6 lines · Loc Ho
Quoted 3 lines · Joe Perches

Section headers should be single line.

Fix it.

Can we drop the "Fix it."

<shrug> I use that frequently.

Quoted 1 line

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

Quoted 4 lines
Quoted 4 lines
MAINTAINERS +0 -0
@@ -5029,8 +5029,7 @@ L:        [email protected]
 S:     Maintained
 F:     drivers/edac/skx_edac.c
Quoted 11 lines

MAINTAINERS L: [email protected] · line 5032

Quoted 3 lines
MAINTAINERS +1 -2
-EDAC-XGENE
-APPLIED MICRO (APM) X-GENE SOC EDAC
+EDAC-XGENE-APPLIED MICRO (APM) X-GENE SOC EDAC

To be consistent with other, how about just:

EDAC-XGENE (drop the Applied micro ... line)

Quoted 3 lines
MAINTAINERS +0 -0
 M:     Loc Ho <[email protected]>
 S:     Supported
 F:     drivers/edac/xgene_edac.c

I don't care one way or another.