Skip to contentSkip to conversation

PCI: armada8k: Check the return value from clk_prepare_enable()

PATCH In review Fabio Estevam 3 participants 3 messages Jul 22, 2017 – Aug 3, 2017 PCI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 PCI: armada8k: Check the return value from clk_prepare_enable()

From: Fabio Estevam <[email protected]>

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error.

---
Changes since v1:
- Improve Subject style

 drivers/pci/dwc/pcie-armada8k.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/dwc/pcie-armada8k.c +3 -1
index ea8f34a..7297223 100644
@@ -226,7 +226,9 @@ static int armada8k_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(pcie->clk))
 		return PTR_ERR(pcie->clk);
 
-	clk_prepare_enable(pcie->clk);
+	ret = clk_prepare_enable(pcie->clk);
+	if (ret)
+		return ret;
 
 	/* Get the dw-pcie unit configuration/control registers base. */
 	base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
Signature · 1 line
2.7.4
#2 lore raw
In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error.

Applied with Thomas' ack to pci/host-armada for v4.14, thanks!

Quoted 25 lines

---
Changes since v1:
- Improve Subject style

 drivers/pci/dwc/pcie-armada8k.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/dwc/pcie-armada8k.c +3 -1
index ea8f34a..7297223 100644
@@ -226,7 +226,9 @@ static int armada8k_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(pcie->clk))
 		return PTR_ERR(pcie->clk);
 
-	clk_prepare_enable(pcie->clk);
+	ret = clk_prepare_enable(pcie->clk);
+	if (ret)
+		return ret;
 
 	/* Get the dw-pcie unit configuration/control registers base. */
 	base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
Signature · 1 line
2.7.4