Skip to contentSkip to conversation

Patch "libnvdimm: fix the clear-error check in nsio_rw_bytes" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

libnvdimm: fix the clear-error check in nsio_rw_bytes

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
libnvdimm-fix-the-clear-error-check-in-nsio_rw_bytes.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7e5a21dfe5524a85705d3bc7b540c849cc13e9a1 Mon Sep 17 00:00:00 2001

From: Vishal Verma <[email protected]>
Date: Fri, 30 Jun 2017 18:32:52 -0600
Subject: libnvdimm: fix the clear-error check in nsio_rw_bytes

From: Vishal Verma <[email protected]>

commit 7e5a21dfe5524a85705d3bc7b540c849cc13e9a1 upstream.

A leftover from the 'bandaid' fix that disabled BTT error clearing in rw_bytes resulted in an incorrect check. After we converted these checks over to use the NVDIMM_IO_ATOMIC flag, the ndns->claim check was both redundant, and incorrect. Remove it.

Fixes 3ae3d67ba705 ("libnvdimm: add an atomic vs process context flag to rw_bytes")
Cc Dave Jiang <[email protected]>
Cc Dan Williams <[email protected]>
---
 drivers/nvdimm/claim.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/nvdimm/claim.c +1 -2
@@ -260,8 +260,7 @@ static int nsio_rw_bytes(struct nd_names
 		 * work around this collision.
 		 */
 		if (IS_ALIGNED(offset, 512) && IS_ALIGNED(size, 512)
-				&& !(flags & NVDIMM_IO_ATOMIC)
-				&& !ndns->claim) {
+				&& !(flags & NVDIMM_IO_ATOMIC)) {
 			long cleared;
 
 			cleared = nvdimm_clear_poison(&ndns->dev,

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/libnvdimm-btt-fix-btt_rw_page-not-returning-errors.patch queue-4.12/libnvdimm-fix-the-clear-error-check-in-nsio_rw_bytes.patch queue-4.12/libnvdimm-fix-badblock-range-handling-of-ars-range.patch