Skip to contentSkip to conversation

Patch "serial: st-asc: Potential error pointer dereference" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

serial: st-asc: Potential error pointer dereference

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
serial-st-asc-potential-error-pointer-dereference.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2b01bfaeb41e1563322448d9b392ac924cbf22ef Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Mon, 17 Jul 2017 11:12:38 +0300
Subject: serial: st-asc: Potential error pointer dereference

From: Dan Carpenter <[email protected]>

commit 2b01bfaeb41e1563322448d9b392ac924cbf22ef upstream.

It looks like we intended to return an error code here, because we dereference "ascport->pinctrl" on the next lines.

Fixes 6929cb00a501 ("serial: st-asc: Read in all Pinctrl states")
---
 drivers/tty/serial/st-asc.c |    1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/st-asc.c +1 -0
@@ -758,6 +758,7 @@ static int asc_init_port(struct asc_port
 	if (IS_ERR(ascport->pinctrl)) {
 		ret = PTR_ERR(ascport->pinctrl);
 		dev_err(&pdev->dev, "Failed to get Pinctrl: %d\n", ret);
+		return ret;
 	}
 
 	ascport->states[DEFAULT] =

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/serial-st-asc-potential-error-pointer-dereference.patch queue-4.12/ipmi-ssif-add-missing-unlock-in-error-branch.patch queue-4.12/serial-sh-sci-uninitialized-variables-in-sysfs-files.patch