Skip to contentSkip to conversation

FAILED: patch "[PATCH] RDMA/uverbs: Fix the check for port number" failed to apply to 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3 Mon Sep 17 00:00:00 2001

From: "Ismail, Mustafa" <[email protected]>
Date: Fri, 14 Jul 2017 09:41:30 -0500
Subject: [PATCH] RDMA/uverbs: Fix the check for port number

The port number is only valid if IB_QP_PORT is set in the mask. So only check port number if it is valid to prevent modify_qp from failing due to an invalid port number.

Fixes 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Cc <[email protected]> # v2.6.14+
drivers/infiniband/core/uverbs_cmd.c +2 -1
index 71451eae42de..2c98533a0203 100644
@@ -1933,7 +1933,8 @@ static int modify_qp(struct ib_uverbs_file *file,
 		goto out;
 	}
 
-	if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) {
+	if ((cmd->base.attr_mask & IB_QP_PORT) &&
+	    !rdma_is_port_valid(qp->device, cmd->base.port_num)) {
 		ret = -EINVAL;
 		goto release_qp;
 	}