Skip to contentSkip to conversation

Patch "RDMA/uverbs: Fix the check for port number" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

RDMA/uverbs: Fix the check for port number

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rdma-uverbs-fix-the-check-for-port-number.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3 Mon Sep 17 00:00:00 2001

From: "Ismail, Mustafa" <[email protected]>
Date: Fri, 14 Jul 2017 09:41:30 -0500
Subject: RDMA/uverbs: Fix the check for port number

From: Ismail, Mustafa <[email protected]>

commit 5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3 upstream.

The port number is only valid if IB_QP_PORT is set in the mask. So only check port number if it is valid to prevent modify_qp from failing due to an invalid port number.

Fixes 5ecce4c9b17b("Check port number supplied by user verbs cmds")
---
 drivers/infiniband/core/uverbs_cmd.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/core/uverbs_cmd.c +2 -1
@@ -1931,7 +1931,8 @@ static int modify_qp(struct ib_uverbs_fi
 		goto out;
 	}
 
-	if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) {
+	if ((cmd->base.attr_mask & IB_QP_PORT) &&
+	    !rdma_is_port_valid(qp->device, cmd->base.port_num)) {
 		ret = -EINVAL;
 		goto release_qp;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/rdma-core-initialize-port_num-in-qp_attr.patch queue-4.12/rdma-uverbs-fix-the-check-for-port-number.patch