Skip to contentSkip to conversation

Patch "vmbus: re-enable channel tasklet" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

vmbus: re-enable channel tasklet

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
vmbus-re-enable-channel-tasklet.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6463a4571ceefc43908df4b016d8d5d8b8e85357 Mon Sep 17 00:00:00 2001

From: Stephen Hemminger <[email protected]>
Date: Sun, 25 Jun 2017 12:47:46 -0700
Subject: vmbus: re-enable channel tasklet

From: Stephen Hemminger <[email protected]>

commit 6463a4571ceefc43908df4b016d8d5d8b8e85357 upstream.

This problem shows up in 4.11 when netvsc driver is removed and reloaded. The problem is that the channel is closed during module removal and the tasklet for processing responses is disabled. When module is reloaded the channel is reopened but the tasklet is marked as disabled. The fix is to re-enable tasklet at the end of close which gets it back to the initial state.

The issue is less urgent in 4.12 since network driver now uses NAPI and not the tasklet; and other VMBUS devices are rarely unloaded/reloaded.

Fixes dad72a1d2844 ("vmbus: remove hv_event_tasklet_disable/enable")
---
 drivers/hv/channel.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/hv/channel.c +2 -0
@@ -606,6 +606,8 @@ static int vmbus_close_internal(struct v
 		get_order(channel->ringbuffer_pagecount * PAGE_SIZE));
 
 out:
+	/* re-enable tasklet for use on re-open */
+	tasklet_enable(&channel->callback_event);
 	return ret;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/vmbus-re-enable-channel-tasklet.patch