Skip to contentSkip to conversation

drm/amd/powerplay: delete PCC error message in smu7_hwmgr.c

PATCH In review Rex Zhu 2 participants 2 messages Jul 27, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Rex Zhu

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: delete PCC error message in smu7_hwmgr.c

In some asics,Really no need to program PCC HW register.

Change-Id Ieebe926334ee2b183ad0dd57fb2e2981b405eb13
---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +0 -3
index 736f193..2d4244f 100644
@@ -1962,9 +1962,6 @@ static int smu7_thermal_parameter_init(struct pp_hwmgr *hwmgr)
 			temp_reg = PHM_SET_FIELD(temp_reg, CNB_PWRMGT_CNTL, DPM_ENABLED, 0x1);
 			break;
 		default:
-			PP_ASSERT_WITH_CODE(0,
-			"Failed to setup PCC HW register! Wrong GPIO assigned for VDDC_PCC_GPIO_PINID!",
-			);
 			break;
 		}
 		cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, ixCNB_PWRMGT_CNTL, temp_reg);
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1501158752-13792-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Rex Zhu
Sent: Thursday, July 27, 2017 8:33 AM
To: [email protected]
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/powerplay: delete PCC error message in smu7_hwmgr.c

Quoted 4 lines

In some asics,Really no need to program PCC HW register.

Change-Id Ieebe926334ee2b183ad0dd57fb2e2981b405eb13
Quoted 26 lines
---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +0 -3
index 736f193..2d4244f 100644
@@ -1962,9 +1962,6 @@ static int smu7_thermal_parameter_init(struct
 pp_hwmgr *hwmgr)
 			temp_reg = PHM_SET_FIELD(temp_reg,
 CNB_PWRMGT_CNTL, DPM_ENABLED, 0x1);
 			break;
 		default:
-			PP_ASSERT_WITH_CODE(0,
-			"Failed to setup PCC HW register! Wrong GPIO
 assigned for VDDC_PCC_GPIO_PINID!",
-			);
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +0 -0
 			break;
 		}
 		cgs_write_ind_register(hwmgr->device,

CGS_IND_REG__SMC, ixCNB_PWRMGT_CNTL, temp_reg);
--
1.9.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx