Skip to contentSkip to conversation

drm/amdgpu: drop old ip definitions for gfxhub and mmhub

PATCH In review Alex Deucher 3 participants 3 messages Jul 28, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: drop old ip definitions for gfxhub and mmhub

The gfxhub and mmhub code are now helpers for gmc rather than standalone IPs. When that changes these were left over. Remove them.

---
 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 2 --
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h  | 3 ---
 2 files changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h +0 -2
index d2dbb08..206e29c 100644
@@ -30,7 +30,5 @@ void gfxhub_v1_0_set_fault_enable_default(struct amdgpu_device *adev,
 					  bool value);
 void gfxhub_v1_0_init(struct amdgpu_device *adev);
 u64 gfxhub_v1_0_get_mc_fb_offset(struct amdgpu_device *adev);
-extern const struct amd_ip_funcs gfxhub_v1_0_ip_funcs;
-extern const struct amdgpu_ip_block_version gfxhub_v1_0_ip_block;
 
 #endif
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h +0 -3
index 57bb940..5d38229 100644
@@ -36,7 +36,4 @@ void mmhub_v1_0_initialize_power_gating(struct amdgpu_device *adev);
 void mmhub_v1_0_update_power_gating(struct amdgpu_device *adev,
                                 bool enable);
 
-extern const struct amd_ip_funcs mmhub_v1_0_ip_funcs;
-extern const struct amdgpu_ip_block_version mmhub_v1_0_ip_block;
-
 #endif
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1501213267-20350-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Acked-by
#2 lore raw
Quoted 5 lines · Alex Deucher

The gfxhub and mmhub code are now helpers for gmc rather than standalone IPs. When that changes these were left over. Remove them.

Quoted 36 lines
---
 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 2 --
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h  | 3 ---
 2 files changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h +0 -2
index d2dbb08..206e29c 100644
@@ -30,7 +30,5 @@ void gfxhub_v1_0_set_fault_enable_default(struct amdgpu_device *adev,
 					  bool value);
 void gfxhub_v1_0_init(struct amdgpu_device *adev);
 u64 gfxhub_v1_0_get_mc_fb_offset(struct amdgpu_device *adev);
-extern const struct amd_ip_funcs gfxhub_v1_0_ip_funcs;
-extern const struct amdgpu_ip_block_version gfxhub_v1_0_ip_block;
 
 #endif
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h +0 -3
index 57bb940..5d38229 100644
@@ -36,7 +36,4 @@ void mmhub_v1_0_initialize_power_gating(struct amdgpu_device *adev);
 void mmhub_v1_0_update_power_gating(struct amdgpu_device *adev,
                                 bool enable);
 
-extern const struct amd_ip_funcs mmhub_v1_0_ip_funcs;
-extern const struct amdgpu_ip_block_version mmhub_v1_0_ip_block;
-
 #endif
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#3 lore raw
In reply to a message not in the archive

Am 28.07.2017 um 05:41 schrieb Alex Deucher:

Quoted 5 lines

The gfxhub and mmhub code are now helpers for gmc rather than standalone IPs. When that changes these were left over. Remove them.

Quoted 22 lines
---
  drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 2 --
  drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h  | 3 ---
  2 files changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h +0 -2
index d2dbb08..206e29c 100644
@@ -30,7 +30,5 @@ void gfxhub_v1_0_set_fault_enable_default(struct amdgpu_device *adev,
  					  bool value);
  void gfxhub_v1_0_init(struct amdgpu_device *adev);
  u64 gfxhub_v1_0_get_mc_fb_offset(struct amdgpu_device *adev);
-extern const struct amd_ip_funcs gfxhub_v1_0_ip_funcs;
-extern const struct amdgpu_ip_block_version gfxhub_v1_0_ip_block;
 
  #endif
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h +0 -0
index 57bb940..5d38229 100644

drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h void mmhub_v1_0_initialize_power_gating(struct amdgpu_device *adev); · line 39

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h +0 -3
@@ -36,7 +36,4 @@ void mmhub_v1_0_initialize_power_gating(struct amdgpu_device *adev);
  void mmhub_v1_0_update_power_gating(struct amdgpu_device *adev,
                                  bool enable);
 
-extern const struct amd_ip_funcs mmhub_v1_0_ip_funcs;
-extern const struct amdgpu_ip_block_version mmhub_v1_0_ip_block;
-
  #endif

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx