Skip to contentSkip to conversation

patch "USB: hcd: Mark secondary HCD as dead if the primary one died" added to usb-linus

PATCH [email protected] 1 participant 1 message Jul 30, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: hcd: Mark secondary HCD as dead if the primary one died

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From cd5a6a4fdaba150089af2afc220eae0fef74878a Mon Sep 17 00:00:00 2001

From: "Rafael J. Wysocki" <[email protected]>
Date: Tue, 25 Jul 2017 23:58:50 +0200
Subject: USB: hcd: Mark secondary HCD as dead if the primary one died

Make usb_hc_died() clear the HCD_FLAG_RH_RUNNING flag for the shared HCD and set HCD_FLAG_DEAD for it, in analogy with what is done for the primary one.

Among other thigs, this prevents check_root_hub_suspended() from returning -EBUSY for dead HCDs which helps to work around system suspend issues in some situations.

This actually fixes occasional suspend failures on one of my test machines.

---
 drivers/usb/core/hcd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/core/hcd.c +2 -0
index ab1bb3b538ac..e518f6438877 100644
@@ -2485,6 +2485,8 @@ void usb_hc_died (struct usb_hcd *hcd)
 	}
 	if (usb_hcd_is_primary_hcd(hcd) && hcd->shared_hcd) {
 		hcd = hcd->shared_hcd;
+		clear_bit(HCD_FLAG_RH_RUNNING, &hcd->flags);
+		set_bit(HCD_FLAG_DEAD, &hcd->flags);
 		if (hcd->rh_registered) {
 			clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
 
Signature · 1 line
2.13.3