Skip to contentSkip to conversation

Patch "powerpc/pseries: Fix of_node_put() underflow during reconfig remove" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 31, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

powerpc/pseries: Fix of_node_put() underflow during reconfig remove

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
powerpc-pseries-fix-of_node_put-underflow-during-reconfig-remove.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4fd1bd443e80b12f0a01a45fb9a793206b41cb72 Mon Sep 17 00:00:00 2001

From: Laurent Vivier <[email protected]>
Date: Fri, 21 Jul 2017 16:51:39 +0200
Subject: powerpc/pseries: Fix of_node_put() underflow during reconfig remove

From: Laurent Vivier <[email protected]>

commit 4fd1bd443e80b12f0a01a45fb9a793206b41cb72 upstream.

As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put() underflow during DLPAR remove"), the call to of_node_put() must be removed from pSeries_reconfig_remove_node().

dlpar_detach_node() and pSeries_reconfig_remove_node() both call of_detach_node(), and thus the node should not be released in both cases.

Fixes 0829f6d1f69e ("of: device_node kobject lifecycle fixes")
---
 arch/powerpc/platforms/pseries/reconfig.c |    1 -
 1 file changed, 1 deletion(-)
arch/powerpc/platforms/pseries/reconfig.c +0 -1
@@ -82,7 +82,6 @@ static int pSeries_reconfig_remove_node(
 
 	of_detach_node(np);
 	of_node_put(parent);
-	of_node_put(np); /* Must decrement the refcount */
 	return 0;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/powerpc-pseries-fix-of_node_put-underflow-during-reconfig-remove.patch