Skip to contentSkip to conversation

staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference

PATCH Daniel Vetter 2 participants 3 messages Aug 2, 2017 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Daniel Vetter

author
#1 lore raw
Quoted 9 lines · Cihangir Akturk

drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should not be used by new code.

This patch fixes the following warning reported by coccinelle:

drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put helpers to reference and dereference obj

Signed-off-by Cihangir Akturk <[email protected]>

Care to do this for all the drm drivers, not just the single one in staging?

Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches also go to dri-devel?

Thanks, Daniel

Quoted 20 lines
---
 drivers/staging/vboxvideo/vbox_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vboxvideo/vbox_main.c +1 -2
index d0c6ec7..1addeac 100644
@@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file,
        bo = gem_to_vbox_bo(obj);
        *offset = vbox_bo_mmap_offset(bo);
 
-       drm_gem_object_unreference(obj);
+       drm_gem_object_put(obj);
        ret = 0;
 
 out_unlock:
--

2.7.4

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 4 lines · Daniel Vetter
Quoted 3 lines · Cihangir Akturk

drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should not be used by new code.

Quoted 8 lines
Quoted 6 lines

This patch fixes the following warning reported by coccinelle:

drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put helpers to reference and dereference obj

Signed-off-by Cihangir Akturk <[email protected]>

Care to do this for all the drm drivers, not just the single one in staging?

Sure, I'll send a v2 shortly as you suggested.

Thanks.

Quoted 5 lines

Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches also go to dri-devel?

Thanks, Daniel

author
#3 lore raw
Quoted 7 lines · Cihangir Akturk
Quoted 6 lines · Daniel Vetter
Quoted 5 lines · Cihangir Akturk

drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should not be used by new code.

This patch fixes the following warning reported by coccinelle:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put helpers to reference and dereference obj

Signed-off-by Cihangir Akturk <[email protected]>

Care to do this for all the drm drivers, not just the single one in staging?

Sure, I'll send a v2 shortly as you suggested.

Patch per driver would be better I think, there's probably going to be a _lot_ of hits.

Thanks, Daniel

Quoted 8 lines

Thanks.

Quoted 5 lines

Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches also go to dri-devel?

Thanks, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel