Skip to contentSkip to conversation

Patch "libnvdimm, btt: fix btt_rw_page not returning errors" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

libnvdimm, btt: fix btt_rw_page not returning errors

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
libnvdimm-btt-fix-btt_rw_page-not-returning-errors.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c13c43d54f2c6a3be1c675766778ac1ad8dfbfcc Mon Sep 17 00:00:00 2001

From: Vishal Verma <[email protected]>
Date: Thu, 29 Jun 2017 16:59:11 -0600
Subject: libnvdimm, btt: fix btt_rw_page not returning errors

From: Vishal Verma <[email protected]>

commit c13c43d54f2c6a3be1c675766778ac1ad8dfbfcc upstream.

btt_rw_page was not propagating errors frm btt_do_bvec, resulting in any IO errors via the rw_page path going unnoticed. the pmem driver recently fixed this in e10624f pmem: fail io-requests to known bad blocks but same problem in BTT went neglected.

Fixes 5212e11fde4d ("nd_btt: atomic sector updates")
Cc Toshi Kani <[email protected]>
Cc Dan Williams <[email protected]>
Cc Jeff Moyer <[email protected]>
---
 drivers/nvdimm/btt.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/nvdimm/btt.c +6 -3
@@ -1205,10 +1205,13 @@ static int btt_rw_page(struct block_devi
 		struct page *page, int rw)
 {
 	struct btt *btt = bdev->bd_disk->private_data;
+	int rc;
 
-	btt_do_bvec(btt, NULL, page, PAGE_CACHE_SIZE, 0, rw, sector);
-	page_endio(page, rw & WRITE, 0);
-	return 0;
+	rc = btt_do_bvec(btt, NULL, page, PAGE_CACHE_SIZE, 0, rw, sector);
+	if (rc == 0)
+		page_endio(page, rw & WRITE, 0);
+
+	return rc;
 }
 
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/libnvdimm-btt-fix-btt_rw_page-not-returning-errors.patch