Skip to contentSkip to conversation

package_manager: Fix support for NO_RECOMMENDATONS

PATCH Applied Richard Röjfors 3 participants 3 messages Aug 7, 2017 – Aug 16, 2017

lore
Share & tools
lore

Richard Röjfors

author
#0 lore raw

PATCH 1/1 package_manager: Fix support for NO_RECOMMENDATONS

When support for dnf was introduced the check of the no NO_RECOMMENDATIONS variable got broken.

This fixes the issue by compairing to the string "1" rather than the number 1.

Signed-off-by Richard Röjfors <[email protected]>

---
 meta/lib/oe/package_manager.py | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/package_manager.py +0 -0
index 93d079d73d..28c6b2aec2 100644
@@ -585,7 +585,7 @@ class RpmPM(PackageManager):


         output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
                          (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
-                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) + +                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) + (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) + ["install"] +
                          pkgs)
--
2.11.0

#1 lore raw

✗ patchtest: failure for package_manager: Fix support for NO_RECOMMENDATONS (rev3)

== Series Details ==

Series: package_manager: Fix support for NO_RECOMMENDATONS (rev3)
Revision: 3
URL : https://patchwork.openembedded.org/series/8021/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series cannot be parsed correctly due to malformed diff lines [test_mbox_format]
Suggested fix Create the series again using git-format-patch and ensure it can be applied using git am
Diff line

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
Applied
#2 lore raw
In reply to Richard Röjfors
Quoted 5 lines · Richard Röjfors

When support for dnf was introduced the check of the no NO_RECOMMENDATIONS variable got broken.

This fixes the issue by compairing to the string "1" rather than the number 1.

merged to stagging.
Thanks,
Armin

Quoted 21 lines
Signed-off-by Richard Röjfors <[email protected]>
---
  meta/lib/oe/package_manager.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/package_manager.py +1 -1
index 93d079d73d..28c6b2aec2 100644
@@ -585,7 +585,7 @@ class RpmPM(PackageManager):
 
          output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
                           (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
-                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) +
+                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) +
                           (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) +
                           ["install"] +
                           pkgs)
Signature · 1 line
2.11.0