Patch "tile: use global strscpy() rather than private copy" has been added to the 3.18-stable tree
This is a note to let you know that I've just added the patch titled
tile: use global strscpy() rather than private copy
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tile-use-global-strscpy-rather-than-private-copy.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
30059d494a72603d066baf55c748803df968aa08Mon Sep 17 00:00:00 2001
From: Chris Metcalf <[email protected]>
Date: Wed, 29 Apr 2015 13:07:38 -0400
Subject: tile: use global strscpy() rather than private copy
From: Chris Metcalf <[email protected]>
commit 30059d494a72603d066baf55c748803df968aa08 upstream.
Now that strscpy() is a standard API, remove the local copy.
--- arch/tile/gxio/mpipe.c | 33 ++++----------------------------- 1 file changed, 4 insertions(+), 29 deletions(-)
arch/tile/gxio/mpipe.c +4 -29
@@ -19,6 +19,7 @@#include <linux/errno.h> #include <linux/io.h> #include <linux/module.h> +#include <linux/string.h> #include <gxio/iorpc_globals.h> #include <gxio/iorpc_mpipe.h>
@@ -29,32 +30,6 @@/* HACK: Avoid pointless "shadow" warnings. */ #define link link_shadow -/** -* strscpy - Copy a C-string into a sized buffer, but only if it fits -* @dest: Where to copy the string to -* @src: Where to copy the string from -* @size: size of destination buffer -* -* Use this routine to avoid copying too-long strings. -* The routine returns the total number of bytes copied -* (including the trailing NUL) or zero if the buffer wasn't -* big enough. To ensure that programmers pay attention -* to the return code, the destination has a single NUL -* written at the front (if size is non-zero) when the -* buffer is not big enough. -*/ -static size_t strscpy (char *dest,const char *src,size_t size) -{ -size_t len =strnlen (src, size) +1 ; -if (len > size) { -if (size) - dest[0 ] ='\0' ; -return 0 ; - } -memcpy (dest, src, len); -return len; -} -int gxio_mpipe_init (gxio_mpipe_context_t *context,unsigned int mpipe_index) {char file[32 ];
@@ -537,7 +512,7 @@ int gxio_mpipe_link_instance(const charif (!context)return GXIO_ERR_NO_DEVICE ; -if (strscpy (name.name, link_name,sizeof (name.name)) ==0 ) +if (strscpy (name.name, link_name,sizeof (name.name)) <0 )return GXIO_ERR_NO_DEVICE ;return gxio_mpipe_info_instance_aux (context, name);
@@ -555,7 +530,7 @@ int gxio_mpipe_link_enumerate_mac(int id rv =gxio_mpipe_info_enumerate_aux (context, idx, &name, &mac);if (rv >=0 ) { -if (strscpy (link_name, name.name,sizeof (name.name)) ==0 ) +if (strscpy (link_name, name.name,sizeof (name.name)) <0 )return GXIO_ERR_INVAL_MEMORY_SIZE ;memcpy (link_mac, mac.mac,sizeof (mac.mac)); }
@@ -572,7 +547,7 @@ int gxio_mpipe_link_open(gxio_mpipe_link_gxio_mpipe_link_name_t name;int rv; -if (strscpy (name.name, link_name,sizeof (name.name)) ==0 ) +if (strscpy (name.name, link_name,sizeof (name.name)) <0 )return GXIO_ERR_NO_DEVICE ; rv =gxio_mpipe_link_open_aux (context, name, flags);
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/strscpy-zero-any-trailing-garbage-bytes-in-the-destination.patch queue-3.18/make-asm-word-at-a-time.h-available-on-all-architectures.patch queue-3.18/word-at-a-time.h-support-zero_bytemask-on-alpha-and-tile.patch queue-3.18/tile-use-global-strscpy-rather-than-private-copy.patch queue-3.18/tile-add-asm-word-at-a-time.h-and-enable-support-functions.patch queue-3.18/string-provide-strscpy.patch queue-3.18/arch-powerpc-provide-zero_bytemask-for-big-endian.patch