Skip to contentSkip to conversation

Patch "drm/amdgpu: Fix undue fallthroughs in golden registers initialization" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Aug 7, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/amdgpu: Fix undue fallthroughs in golden registers initialization

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-amdgpu-fix-undue-fallthroughs-in-golden-registers-initialization.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5694785cf09bf0e7bd8e5f62361ea34fa162a4a0 Mon Sep 17 00:00:00 2001

From: Jean Delvare <[email protected]>
Date: Sun, 30 Jul 2017 10:18:25 +0200
Subject: drm/amdgpu: Fix undue fallthroughs in golden registers initialization
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Jean Delvare <[email protected]>

commit 5694785cf09bf0e7bd8e5f62361ea34fa162a4a0 upstream.

As I was staring at the si_init_golden_registers code, I noticed that the Pitcairn initialization silently falls through the Cape Verde initialization, and the Oland initialization falls through the Hainan initialization. However there is no comment stating that this is intentional, and the radeon driver doesn't have any such fallthrough, so I suspect this is not supposed to happen.

Fixes 62a37553414a ("drm/amdgpu: add si implementation v10")
Cc Ken Wang <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Marek Olšák" <[email protected]>
Cc "Christian König" <[email protected]>
Cc Flora Cui <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/si.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/si.c +2 -0
@@ -1301,6 +1301,7 @@ static void si_init_golden_registers(str
 		amdgpu_program_register_sequence(adev,
 						 pitcairn_mgcg_cgcg_init,
 						 (const u32)ARRAY_SIZE(pitcairn_mgcg_cgcg_init));
+		break;
 	case CHIP_VERDE:
 		amdgpu_program_register_sequence(adev,
 						 verde_golden_registers,
@@ -1325,6 +1326,7 @@ static void si_init_golden_registers(str
 		amdgpu_program_register_sequence(adev,
 						 oland_mgcg_cgcg_init,
 						 (const u32)ARRAY_SIZE(oland_mgcg_cgcg_init));
+		break;
 	case CHIP_HAINAN:
 		amdgpu_program_register_sequence(adev,
 						 hainan_golden_registers,

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/drm-amdgpu-fix-undue-fallthroughs-in-golden-registers-initialization.patch