Skip to contentSkip to conversation

WTF: patch "[PATCH] ext4: error should be cleared if ea_inode isn't added to the" was seriously submitted to be applied to the 4.12-stable tree?

PATCH [email protected] 1 participant 1 message Aug 7, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below was submitted to be applied to the 4.12-stable tree.

I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst.

I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 191eac33009e6a6d31e87cfa425a20d0e79704b4 Mon Sep 17 00:00:00 2001

From: Emoly Liu <[email protected]>
Date: Mon, 31 Jul 2017 00:40:22 -0400
Subject: [PATCH] ext4: error should be cleared if ea_inode isn't added to the
cache

For Lustre, if ea_inode fails in hash validation but passes parent inode and generation checks, it won't be added to the cache as well as the error "-EFSCORRUPTED" should be cleared, otherwise it will cause "Structure needs cleaning" when running getfattr command.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9723

Fixes dec214d00e0d78a08b947d7dccdfdb84407a9f4d
Reviewed-by [email protected]
fs/ext4/xattr.c +1 -0
index cff4f41ced61..de217a094733 100644
@@ -451,6 +451,7 @@ ext4_xattr_inode_get(struct inode *inode, struct ext4_xattr_entry *entry,
 		}
 		/* Do not add ea_inode to the cache. */
 		ea_inode_cache = NULL;
+		err = 0;
 	} else if (err)
 		goto out;