Staging: comedi: addi_apci_3501: fixed a CamelCase coding style issue
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 22 lines · Chi-Chun Hsu
Fixed a coding style issue.
Signed-off-by Chi-Chun Hsu <[email protected]>--- drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/comedi/drivers/addi_apci_3501.c +1
-1@@ -68,7 +68,7 @@struct apci3501_private {unsigned long amcc;unsigned long tcw; -struct task_struct *tsk_Current; +struct task_struct *tsk_current;unsigned char timer_mode; };
drivers/staging/comedi/drivers/addi_apci_3501.c static irqreturn_t apci3501_interrupt(int irq, void *d) · line 279
Quoted 8 lines
drivers/staging/comedi/drivers/addi_apci_3501.c +1
-1@@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d) }/* Enable Interrupt Send a signal to from kernel to user space */ -send_sig (SIGIO , devpriv->tsk_Current,0 ); +send_sig (SIGIO , devpriv->tsk_current,0 ); ctrl =inl (devpriv->tcw +ADDI_TCW_CTRL_REG ); ctrl &= ~(ADDI_TCW_CTRL_GATE |ADDI_TCW_CTRL_TRIG |ADDI_TCW_CTRL_IRQ_ENA );
This patch is incomplete (the 'tsk_Current' member is also used in "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in kernel version 4.9 by commit a6672530f6fc ("staging: comedi: addi_apci_3501: remove timer/counter subdevice support").
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=- -=( Web: http://www.mev.co.uk/ )=-
Quoted 6 lines
This patch is incomplete (the '
tsk_Current' member is also used in "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in kernel version 4.9 by commita6672530f6fc("staging: comedi:addi_apci_3501:
remove timer/counter subdevice support").
Got it, great thanks for your detailed reply.
2017-08-08 17:40 GMT+08:00 Ian Abbott <[email protected]>:
Quoted 42 lines · Chi-Chun Hsu
Quoted 26 lines
Fixed a coding style issue.
Signed-off-by Chi-Chun Hsu <[email protected]>--- drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/comedi/drivers/addi_apci_3501.c +1
-1@@ -68,7 +68,7 @@struct apci3501_private {unsigned long amcc;unsigned long tcw; -struct task_struct *tsk_Current; +struct task_struct *tsk_current;unsigned char timer_mode; }; @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void*d)
} /* Enable Interrupt Send a signal to from kernel to user space */drivers/staging/comedi/drivers/addi_apci_3501.c
Quoted 5 lines
drivers/staging/comedi/drivers/addi_apci_3501.c +1
-1-send_sig (SIGIO , devpriv->tsk_Current,0 ); +send_sig (SIGIO , devpriv->tsk_current,0 ); ctrl =inl (devpriv->tcw +ADDI_TCW_CTRL_REG ); ctrl &= ~(ADDI_TCW_CTRL_GATE |ADDI_TCW_CTRL_TRIG |ADDI_TCW_CTRL_IRQ_ENA );This patch is incomplete (the '
tsk_Current' member is also used in "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in kernel version 4.9 by commita6672530f6fc("staging: comedi:addi_apci_3501:
remove timer/counter subdevice support").--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-