Skip to contentSkip to conversation

staging: vboxvideo: make drm_fb_helper_funcs const

PATCH In review Bhumika Goyal 2 participants 3 messages Aug 8, 2017 – Aug 17, 2017 Staging

lore
Share & tools
lore

Bhumika Goyal

author
#0 lore raw

PATCH 1/1 staging: vboxvideo: make drm_fb_helper_funcs const

Make the structure const as it is only passed to the function drm_fb_helper_prepare and the corresponding argument is of type const.
Done using Coccinelle.

Signed-off-by Bhumika Goyal <[email protected]>
---
 drivers/staging/vboxvideo/vbox_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vboxvideo/vbox_fb.c +1 -1
index bf66358..c386039 100644
@@ -317,7 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper,
 	return 0;
 }
 
-static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
+static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
 	.fb_probe = vboxfb_create,
 };
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 9 lines · Bhumika Goyal

Make the structure const as it is only passed to the function drm_fb_helper_prepare and the corresponding argument is of type const.
Done using Coccinelle.

Signed-off-by Bhumika Goyal <[email protected]>
---
 drivers/staging/vboxvideo/vbox_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree at all :(

author
#2 lore raw
Quoted 6 lines · Greg KH
Quoted 5 lines · Bhumika Goyal

Make the structure const as it is only passed to the function drm_fb_helper_prepare and the corresponding argument is of type const.
Done using Coccinelle.

Quoted 6 lines
Quoted 4 lines
Signed-off-by Bhumika Goyal <[email protected]>
---
 drivers/staging/vboxvideo/vbox_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree at all :(

Okay, I will resend it.

Thanks,
Bhumika