Skip to contentSkip to conversation

Patch "dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
dccp-fix-a-memleak-that-dccp_ipv4-doesn-t-put-reqsk-properly.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Tue Aug 8 16:27:53 PDT 2017

From: Xin Long <[email protected]>
Date: Wed, 26 Jul 2017 14:19:46 +0800
Subject: dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly

From: Xin Long <[email protected]>

[ Upstream commit b7953d3c0e30a5fc944f6b7bd0bcceb0794bcd85 ]

The patch "dccp: fix a memleak that dccp_ipv6 doesn't put reqsk properly" fixed reqsk refcnt leak for dccp_ipv6. The same issue exists on dccp_ipv4.

This patch is to fix it for dccp_ipv4.

---
 net/dccp/ipv4.c |    1 +
 1 file changed, 1 insertion(+)
net/dccp/ipv4.c +1 -0
@@ -637,6 +637,7 @@ int dccp_v4_conn_request(struct sock *sk
 		goto drop_and_free;
 
 	inet_csk_reqsk_queue_hash_add(sk, req, DCCP_TIMEOUT_INIT);
+	reqsk_put(req);
 	return 0;
 
 drop_and_free:

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/sctp-fix-the-check-for-_sctp_walk_params-and-_sctp_walk_errors.patch queue-4.9/dccp-fix-a-memleak-that-dccp_ipv6-doesn-t-put-reqsk-properly.patch queue-4.9/dccp-fix-a-memleak-that-dccp_ipv4-doesn-t-put-reqsk-properly.patch queue-4.9/dccp-fix-a-memleak-for-dccp_feat_init-err-process.patch