patch "fpga: altera-hps2fpga: fix multiple init of l3_remap_lock" added to char-misc-testing
Subsystems (2)
This is a note to let you know that I've just added the patch titled
fpga: altera-hps2fpga: fix multiple init of l3_remap_lock
to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-testing branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will be merged to the char-misc-next branch sometime soon, after it passes testing, and the merge window is open.
If you have any questions about this process, please let me know.
Quoted 1 line
From
4ae2bd4b3ada3dfd80ca8110b4f567752966ca1eMon Sep 17 00:00:00 2001
From: Ian Abbott <[email protected]>
Date: Tue, 1 Aug 2017 21:20:54 -0500
Subject: fpga: altera-hps2fpga: fix multiple init of l3_remap_lock
The global spinlock l3_remap_lock is reinitialized every time the "probe" function alt_fpga_bridge_probe() is called. It should only be initialized once. Use DEFINE_SPINLOCK() to initialize it statically.
--- drivers/fpga/altera-hps2fpga.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/fpga/altera-hps2fpga.c +1 -3
@@ -66,7 +66,7 @@ static int alt_hps2fpga_enable_show(struct fpga_bridge *bridge)/* The L3 REMAP register is write only, so keep a cached value. */ static unsigned int l3_remap_shadow; -static spinlock_t l3_remap_lock; +static DEFINE_SPINLOCK (l3_remap_lock);static int _alt_hps2fpga_enable_set (struct altera_hps2fpga_data *priv,bool enable)
@@ -177,8 +177,6 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)return -EBUSY ; } -spin_lock_init (&l3_remap_lock); -if (!of_property_read_u32 (dev->of_node,"bridge-enable" , &enable)) {if (enable >1 ) {dev_warn (dev,"invalid bridge-enable %u > 1\n" , enable);
Signature · 1 line
2.14.0