Convert CONFIG_BCH to Kconfig

PATCH In review Adam Ford 2 participants 3 messages Aug 11, 2017 – Sep 2, 2017 Library code

lore

Share & tools

lore

Adam Ford

author

2017-08-11 14:46 UTC #0 lore raw

PATCH 1/1 Convert CONFIG_BCH to Kconfig

This converts the following to Kconfig:
CONFIG_BCH

Signed-off-by Adam Ford <[email protected]>

---
 configs/am3517_evm_defconfig         | 1 +
 configs/igep0020_defconfig           | 1 +
 configs/igep0030_defconfig           | 1 +
 configs/igep0032_defconfig           | 1 +
 configs/km_kirkwood_128m16_defconfig | 1 +
 configs/km_kirkwood_defconfig        | 1 +
 configs/km_kirkwood_pci_defconfig    | 1 +
 configs/kmcoge4_defconfig            | 1 +
 configs/kmcoge5ne_defconfig          | 1 +
 configs/kmcoge5un_defconfig          | 1 +
 configs/kmlion1_defconfig            | 1 +
 configs/kmnusa_defconfig             | 1 +
 configs/kmsugp1_defconfig            | 1 +
 configs/kmsuv31_defconfig            | 1 +
 configs/kmtegr1_defconfig            | 1 +
 configs/mgcoge3un_defconfig          | 1 +
 configs/omap3_logic_defconfig        | 1 +
 configs/omap3_overo_defconfig        | 1 +
 configs/portl2_defconfig             | 1 +
 configs/tricorder_defconfig          | 1 +
 configs/tricorder_flash_defconfig    | 1 +
 configs/x600_defconfig               | 1 +
 doc/README.nand                      | 6 ------
 include/configs/am3517_evm.h         | 1 -
 include/configs/km/km_arm.h          | 1 -
 include/configs/km/kmp204x-common.h  | 2 --
 include/configs/km8360.h             | 1 -
 include/configs/omap3_igep00x0.h     | 1 -
 include/configs/omap3_logic.h        | 1 -
 include/configs/omap3_overo.h        | 2 --
 include/configs/suvd3.h              | 1 -
 include/configs/tricorder.h          | 1 -
 include/configs/x600.h               | 1 -
 lib/Kconfig                          | 7 +++++++
 scripts/config_whitelist.txt         | 1 -
 35 files changed, 29 insertions(+), 19 deletions(-)

configs/am3517_evm_defconfig +1 -0

index 4e4aadb..c7e7dc4 100644
@@ -43,4 +43,5 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_STORAGE=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/igep0020_defconfig +1 -0

index 745d6f6..41ac579 100644
@@ -41,5 +41,6 @@ CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_MTD_UBI_FASTMAP=y
 CONFIG_SYS_NS16550=y
 CONFIG_FAT_WRITE=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y
 CONFIG_FDT_FIXUP_PARTITIONS=y

configs/igep0030_defconfig +1 -0

index 48b80ae..14397c5 100644
@@ -40,5 +40,6 @@ CONFIG_MMC_OMAP_HS=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_FAT_WRITE=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y
 CONFIG_FDT_FIXUP_PARTITIONS=y

configs/igep0032_defconfig +1 -0

index 8ecd6a5..c44cb15 100644
@@ -32,5 +32,6 @@ CONFIG_MMC_OMAP_HS=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_FAT_WRITE=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y
 CONFIG_FDT_FIXUP_PARTITIONS=y

configs/km_kirkwood_128m16_defconfig +1 -0

index bbc43c0..100c337 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/km_kirkwood_defconfig +1 -0

index 5a0bafe..330805a 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/km_kirkwood_pci_defconfig +1 -0

index 5c58244..85588ae 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmcoge4_defconfig +1 -0

index 854b4d2..437990f 100644
@@ -39,4 +39,5 @@ CONFIG_PHY_GIGE=y
 CONFIG_E1000=y
 CONFIG_SYS_NS16550=y
 CONFIG_FSL_ESPI=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmcoge5ne_defconfig +1 -0

index 16f51da..a49e9ae 100644
@@ -25,4 +25,5 @@ CONFIG_CMD_UBI=y
 CONFIG_MTD_NOR_FLASH=y
 # CONFIG_PCI is not set
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmcoge5un_defconfig +1 -0

index 333130e..044c06a 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmlion1_defconfig +1 -0

index c01d2af..28f4631 100644
@@ -39,4 +39,5 @@ CONFIG_PHY_GIGE=y
 CONFIG_E1000=y
 CONFIG_SYS_NS16550=y
 CONFIG_FSL_ESPI=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmnusa_defconfig +1 -0

index fc8be93..1a0ab5b 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmsugp1_defconfig +1 -0

index 7ddc3f9..985cc87 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmsuv31_defconfig +1 -0

index 0305572..945b388 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/kmtegr1_defconfig +1 -0

index 618d9df..f5569fd 100644
@@ -25,4 +25,5 @@ CONFIG_CMD_UBI=y
 CONFIG_MTD_NOR_FLASH=y
 # CONFIG_PCI is not set
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/mgcoge3un_defconfig +1 -0

index cf169e3..063cd62 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/omap3_logic_defconfig +1 -0

index 959c71f..990074f 100644
@@ -43,3 +43,4 @@ CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_G_DNL_MANUFACTURER="TI"
 CONFIG_G_DNL_VENDOR_NUM=0x0451
 CONFIG_G_DNL_PRODUCT_NUM=0xd022
+CONFIG_BCH=y

configs/omap3_overo_defconfig +1 -0

index cc30836..5d0bc5f 100644
@@ -47,4 +47,5 @@ CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_FAT_WRITE=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/portl2_defconfig +1 -0

index 146d297..2078e46 100644
@@ -28,4 +28,5 @@ CONFIG_CMD_UBI=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/tricorder_defconfig +1 -0

index de42b4d..b2bfeb7 100644
@@ -36,4 +36,5 @@ CONFIG_LED_STATUS_STATE2=2
 CONFIG_LED_STATUS_CMD=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/tricorder_flash_defconfig +1 -0

index c7cb0f7..4deefb8 100644
@@ -36,4 +36,5 @@ CONFIG_LED_STATUS_STATE2=2
 CONFIG_LED_STATUS_CMD=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_SYS_NS16550=y
+CONFIG_BCH=y
 CONFIG_OF_LIBFDT=y

configs/x600_defconfig +1 -0

index 98b1880..fd3e051 100644
@@ -43,6 +43,7 @@ CONFIG_ETH_DESIGNWARE=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
+CONFIG_BCH=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_OF_LIBFDT=y
 # CONFIG_EFI_LOADER is not set

doc/README.nand +0 -6

index 2295bb2..362b8d8 100644
@@ -180,12 +180,6 @@ Configuration Options:
 	And fetching device parameters flashed on device, by parsing
 	ONFI parameter page.
 
-   CONFIG_BCH
-	Enables software based BCH ECC algorithm present in lib/bch.c
-	This is used by SoC platforms which do not have built-in ELM
-	hardware engine required for BCH ECC correction.
-
-
 Platform specific options
 =========================
    CONFIG_NAND_OMAP_GPMC

include/configs/am3517_evm.h +0 -1

index 65b6af3..fcc1e66 100644
@@ -104,7 +104,6 @@
 
 /* Board NAND Info. */
 #ifdef CONFIG_NAND
-#define CONFIG_BCH
 #define CONFIG_SYS_NAND_ADDR		NAND_BASE	/* physical address */
 							/* to access nand */
 #define CONFIG_SYS_NAND_BASE		NAND_BASE	/* physical address */

include/configs/km/km_arm.h +0 -1

index 42a6032..8866658 100644
@@ -31,7 +31,6 @@
 #define CONFIG_MACH_TYPE	MACH_TYPE_KM_KIRKWOOD
 
 #define CONFIG_NAND_ECC_BCH
-#define CONFIG_BCH
 
 /* include common defines/options for all Keymile boards */
 #include "keymile-common.h"

include/configs/km/kmp204x-common.h +0 -2

index be4a2d0..6480df4 100644
@@ -154,8 +154,6 @@ unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
 #define CONFIG_SYS_NAND_BLOCK_SIZE    (128 * 1024)
 
-#define CONFIG_BCH
-
 /* NAND flash config */
 #define CONFIG_SYS_NAND_BR_PRELIM  (BR_PHYS_ADDR(CONFIG_SYS_NAND_BASE_PHYS) \
 			       | BR_PS_8	       /* Port Size = 8 bit */ \

include/configs/km8360.h +0 -1

index 9c1c158..f482e2c 100644
@@ -22,7 +22,6 @@
 #define CONFIG_KM_BOARD_NAME	"kmcoge5ne"
 #define CONFIG_KM_DEF_NETDEV	"netdev=eth1\0"
 #define CONFIG_NAND_ECC_BCH
-#define CONFIG_BCH
 #define CONFIG_NAND_KMETER1
 #define CONFIG_SYS_MAX_NAND_DEVICE		1
 #define NAND_MAX_CHIPS				1

include/configs/omap3_igep00x0.h +0 -1

index 1182cf5..4fb7102 100644
@@ -114,7 +114,6 @@
 #define CONFIG_SYS_NAND_ECCSIZE		512
 #define CONFIG_SYS_NAND_ECCBYTES	14
 #define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
-#define CONFIG_BCH
 
 /* UBI configuration */
 #define CONFIG_SPL_UBI			1

include/configs/omap3_logic.h +0 -1

index be7e458..647dfc2 100644
@@ -91,7 +91,6 @@
 #define CONFIG_SYS_NAND_ECCSIZE		512
 #define CONFIG_SYS_NAND_ECCBYTES	13
 #define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
-#define CONFIG_BCH
 #define CONFIG_SYS_NAND_MAX_OOBFREE	2
 #define CONFIG_SYS_NAND_MAX_ECCPOS	56
 #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000

include/configs/omap3_overo.h +0 -2

index d7999a9..264a611 100644
@@ -18,8 +18,6 @@
 #undef CONFIG_SPL_TEXT_BASE
 #define CONFIG_SPL_TEXT_BASE		0x40200000
 
-#define CONFIG_BCH
-
 /* call misc_init_r */
 #define CONFIG_MISC_INIT_R

include/configs/suvd3.h +0 -1

index 7b3b050..00deed6 100644
@@ -58,7 +58,6 @@
 #define CONFIG_ENV_OFFSET	0x100000
 
 #define CONFIG_NAND_ECC_BCH
-#define CONFIG_BCH
 #define CONFIG_NAND_KMETER1
 #define CONFIG_SYS_MAX_NAND_DEVICE		1
 #define NAND_MAX_CHIPS				1

include/configs/tricorder.h +0 -1

index 87c2f90..497fbb7 100644
@@ -91,7 +91,6 @@
 							/* CS0 */
 #define CONFIG_SYS_MAX_NAND_DEVICE	1		/* Max number of NAND */
 							/* devices */
-#define CONFIG_BCH
 #define CONFIG_SYS_NAND_MAX_OOBFREE	2
 #define CONFIG_SYS_NAND_MAX_ECCPOS	56

include/configs/x600.h +0 -1

index 18167a8..4c9afa5 100644
@@ -64,7 +64,6 @@
 #define CONFIG_SYS_FSMC_NAND_8BIT
 #define CONFIG_SYS_NAND_ONFI_DETECTION
 #define CONFIG_NAND_ECC_BCH
-#define CONFIG_BCH
 
 /* UBI/UBI config options */
 #define CONFIG_MTD_DEVICE

lib/Kconfig +7 -0

index 2f5a210..1194345 100644
@@ -1,5 +1,12 @@
 menu "Library routines"
 
+config BCH
+	bool "Enable Software based BCH ECC"
+	help
+	  Enables software based BCH ECC algorithm present in lib/bch.c
+	  This is used by SoC platforms which do not have built-in ELM
+	  hardware engine required for BCH ECC correction.
+
 config CC_OPTIMIZE_LIBS_FOR_SPEED
 	bool "Optimize libraries for speed"
 	help

scripts/config_whitelist.txt +0 -1

index d42e839..ae19714 100644
@@ -151,7 +151,6 @@ CONFIG_BARIX_IPAM390
 CONFIG_BAT_CMD
 CONFIG_BAT_PAIR
 CONFIG_BAT_RW
-CONFIG_BCH
 CONFIG_BCH_CONST_M
 CONFIG_BCH_CONST_PARAMS
 CONFIG_BCH_CONST_T

Signature · 1 line

2.7.4

Tom Rini

2017-08-13 21:20 UTC #1 lore raw

PATCH 1/1 Convert CONFIG_BCH to Kconfig

Quoted 4 lines · Adam Ford

This converts the following to Kconfig:
CONFIG_BCH
Signed-off-by Adam Ford <[email protected]>

The diffstat will get reworked once more options are moved to Kconfig and e.g. CONFIG_NAND_OMAP_ELM will select BCH.

Reviewed-by Tom Rini <[email protected]>

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170813/2390d720/attachment.sig>

Tom Rini

2017-09-02 01:58 UTC #2 lore raw

In reply to Adam Ford

Quoted 5 lines · Adam Ford

This converts the following to Kconfig:
CONFIG_BCH
Signed-off-by Adam Ford <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170901/fc9e6d48/attachment.sig>