Skip to contentSkip to conversation

Kconfig: Add EEPROM options to Kconfig when I2C_EEPROM is set

PATCH In review Adam Ford 3 participants 3 messages Aug 13, 2017 – Sep 3, 2017 Char and misc drivers

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 Kconfig: Add EEPROM options to Kconfig when I2C_EEPROM is set

Add the following options to drivers/misc/Kconfig:
SYS_I2C_EEPROM_ADDR SYS_I2C_EEPROM_BUS
SYS_EEPROM_SIZE SYS_EEPROM_PAGE_WRITE_BITS SYS_EEPROM_PAGE_WRITE_DELAY_MS SYS_I2C_EEPROM_ADDR_LEN SYS_I2C_EEPROM_ADDR_OVERFLOW

This does not migrate any boards, but provides a foundations for those who want/need these options

---
 common/Kconfig       | 30 ------------------------------
 drivers/misc/Kconfig | 45 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 30 deletions(-)
common/Kconfig +0 -30
index 0983891..aa50b03 100644
@@ -204,40 +204,10 @@ config ENV_IS_IN_EEPROM
 	  These two #defines specify the offset and size of the
 	  environment area within the total memory of your EEPROM.
 
-	  - CONFIG_SYS_I2C_EEPROM_ADDR:
-	  If defined, specified the chip address of the EEPROM device.
-	  The default address is zero.
-
-	  - CONFIG_SYS_I2C_EEPROM_BUS:
-	  If defined, specified the i2c bus of the EEPROM device.
-
-	  - CONFIG_SYS_EEPROM_PAGE_WRITE_BITS:
-	  If defined, the number of bits used to address bytes in a
-	  single page in the EEPROM device.  A 64 byte page, for example
-	  would require six bits.
-
-	  - CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS:
-	  If defined, the number of milliseconds to delay between
-	  page writes.	The default is zero milliseconds.
-
-	  - CONFIG_SYS_I2C_EEPROM_ADDR_LEN:
-	  The length in bytes of the EEPROM memory array address.  Note
-	  that this is NOT the chip address length!
-
-	  - CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW:
-	  EEPROM chips that implement "address overflow" are ones
-	  like Catalyst 24WC04/08/16 which has 9/10/11 bits of
-	  address and the extra bits end up in the "chip address" bit
-	  slots. This makes a 24WC08 (1Kbyte) chip look like four 256
-	  byte chips.
-
 	  Note that we consider the length of the address field to
 	  still be one byte because the extra address bits are hidden
 	  in the chip address.
 
-	  - CONFIG_SYS_EEPROM_SIZE:
-	  The size in bytes of the EEPROM device.
-
 	  - CONFIG_ENV_EEPROM_IS_ON_I2C
 	  define this, if you have I2C and SPI activated, and your
 	  EEPROM, which holds the environment, is on the I2C bus.
drivers/misc/Kconfig +45 -0

49 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 Kconfig: Add EEPROM options to Kconfig when I2C_EEPROM is set

Hi Adam,

Quoted 11 lines · Adam Ford

Add the following options to drivers/misc/Kconfig:
SYS_I2C_EEPROM_ADDR SYS_I2C_EEPROM_BUS
SYS_EEPROM_SIZE SYS_EEPROM_PAGE_WRITE_BITS SYS_EEPROM_PAGE_WRITE_DELAY_MS SYS_I2C_EEPROM_ADDR_LEN SYS_I2C_EEPROM_ADDR_OVERFLOW

This does not migrate any boards, but provides a foundations for those who want/need these options

Perhaps Tom will migrate them when applying?

Most of these settings should go in device tree, not CONFIG.

Regards,
Simon

#2 lore raw
In reply to Adam Ford
Quoted 9 lines · Adam Ford

Add the following options to drivers/misc/Kconfig:
SYS_I2C_EEPROM_ADDR SYS_I2C_EEPROM_BUS
SYS_EEPROM_SIZE SYS_EEPROM_PAGE_WRITE_BITS SYS_EEPROM_PAGE_WRITE_DELAY_MS SYS_I2C_EEPROM_ADDR_LEN SYS_I2C_EEPROM_ADDR_OVERFLOW

Quoted 4 lines

This does not migrate any boards, but provides a foundations for those who want/need these options

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170902/4d5677ee/attachment.sig>