Skip to contentSkip to conversation

Patch "pinctrl: samsung: Remove bogus irq_[un]mask from resource management" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Aug 14, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pinctrl: samsung: Remove bogus irq_[un]mask from resource management

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pinctrl-samsung-remove-bogus-irq_mask-from-resource-management.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3fa53ec2ed885b0aec3f0472e3b4a8a6f1cd748c Mon Sep 17 00:00:00 2001

From: Thomas Gleixner <[email protected]>
Date: Thu, 29 Jun 2017 23:33:35 +0200
Subject: pinctrl: samsung: Remove bogus irq_[un]mask from resource management

From: Thomas Gleixner <[email protected]>

commit 3fa53ec2ed885b0aec3f0472e3b4a8a6f1cd748c upstream.

The irq chip callbacks irq_request/release_resources() have absolutely no business with masking and unmasking the irq.

The core code unmasks the interrupt after complete setup and masks it before invoking irq_release_resources().

The unmask is actually harmful as it happens before the interrupt is completely initialized in __setup_irq().

Remove it.

Fixes f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
Cc Krzysztof Kozlowski <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Kukjin Kim <[email protected]>
---
 drivers/pinctrl/samsung/pinctrl-exynos.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/pinctrl/samsung/pinctrl-exynos.c +0 -4
@@ -200,8 +200,6 @@ static int exynos_irq_request_resources(
 
 	spin_unlock_irqrestore(&bank->slock, flags);
 
-	exynos_irq_unmask(irqd);
-
 	return 0;
 }
 
@@ -222,8 +220,6 @@ static void exynos_irq_release_resources
 	shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC];
 	mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;
 
-	exynos_irq_mask(irqd);
-
 	spin_lock_irqsave(&bank->slock, flags);
 
 	con = readl(d->virt_base + reg_con);

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/pinctrl-samsung-remove-bogus-irq_mask-from-resource-management.patch