drm/i915: Do not do link training fallback or prune modes for eDP
Subsystems (2)
PATCH 1/1 drm/i915: Do not do link training fallback or prune modes for eDP
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 };* If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp (struct intel_dp *intel_dp) +bool is_edp (struct intel_dp *intel_dp) {struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);
drivers/gpu/drm/i915/intel_dp_link_training.c +2 -1
@@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->base.base.id, intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); -if (!intel_dp_get_link_train_fallback_values (intel_dp, +/* Dont fallback and prune modes if its eDP */ +if (!is_edp (intel_dp) && !intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))/* Schedule a Hotplug Uevent to userspace to start modeset */
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) }bool intel_dp_read_dpcd (struct intel_dp *intel_dp); +bool is_edp (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv,
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Manasi Navare
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
Quoted 4 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Quoted 62 lines
Cc Jani Nikula <[email protected]>Cc Jim Bride <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000,540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp (struct intel_dp *intel_dp) +bool is_edp (struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port =
dp_to_dig_port(intel_dp);drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->base.base.id, intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); -if (!intel_dp_get_link_train_fallback_values (intel_dp, +/* Dont fallback and prune modes if its eDP */ +if (!is_edp (intel_dp) && !intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))/* Schedule a Hotplug Uevent to userspace to start modeset*/
drivers/gpu/drm/i915/intel_drv.h +1
-0@@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) }bool intel_dp_read_dpcd (struct intel_dp *intel_dp); +bool is_edp (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes);bool intel_digital_port_connected(struct
drm_i915_private*dev_priv,
--
2.1.4
Quoted 5 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
Quoted 5 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.
Regards
Manasi
Quoted 70 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
Quoted 10 lines
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Manasi Navare
Quoted 7 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
Quoted 7 lines
Quoted 1 line
What about downclock modes?!
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
fwiw I've got two laptops with eDP's having more than ten modes.
Quoted 95 lines
Quoted 5 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.Regards
ManasiQuoted 70 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
Quoted 10 lines
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Dhinakaran
Quoted 10 lines · Manasi Navare
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
Quoted 7 lines
Quoted 5 lines
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
fwiw I've got two laptops with eDP's having more than ten modes.
those ten are probably a list of modes with scaler right?!
Anyways, there are eDP panels that supports multiple modes like same resolution but different clocks.
Like the ones with 60Hz and 48Hz where we cannot get PSR on 60 and can get on 48 one.
This made Jim to do this patch:
https://patchwork.freedesktop.org/patch/msgid/[email protected]
that now is merged already and allow we select different modes on eDP per request.
this case proves that there are eDP panels out there where this bug wouldn't occur.
So I think we need to find a different way to handle this case where there is no other mode
or fix the link status somehow....
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518
Please add this for reference in a future patch or version:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101518
Quoted 91 lines
Quoted 91 lines
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.
Regards
ManasiQuoted 70 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
Quoted 10 lines
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 34 lines · Rodrigo Vivi
Quoted 11 lines · Dhinakaran
Quoted 10 lines · Manasi Navare
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
Quoted 7 lines
Quoted 5 lines
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
fwiw I've got two laptops with eDP's having more than ten modes.
those ten are probably a list of modes with scaler right?!
Anyways, there are eDP panels that supports multiple modes like same resolution but different clocks.
Like the ones with 60Hz and 48Hz where we cannot get PSR on 60 and can get on 48 one.This made Jim to do this patch:
https://patchwork.freedesktop.org/patch/msgid/[email protected]that now is merged already and allow we select different modes on eDP per request.
Quoted 7 lines
this case proves that there are eDP panels out there where this bug wouldn't occur.
So I think we need to find a different way to handle this case where there is no other mode
or fix the link status somehow....
Thanks Rodrigo for this explanation. Yes those modes advertised to the userspace would be the modes with scalar. But the HW would still only support the fixed mode ot the alternate DRRS mode. Infact in case of link training fallback, when the userspace triggers a new modeset, it will call mode_valid() hook where if the requested mode's hdisplay or vdisplay are greater than the fixed mode's hdisplay or vdisplay then it returns error MODE_PANEL instead of MODE_OK. Also Jim brought up a point that for some eDP panels only 2 lanes could be wired in which case we do want link train fallback in order to retry modeset with fewer lanes. So we need fallback I suppose but handle this no mode situation differently.
Daniel, Jani any thoughts on how this could be handled?
Regards
Manasi
Quoted 101 lines
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518Please add this for reference in a future patch or version:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101518
Quoted 87 lines
Quoted 87 lines
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.
Regards
ManasiQuoted 80 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 14 lines · PDT Rodrigo Vivi
On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran
Quoted 11 lines · <[email protected]> wrote:
Quoted 10 lines · Manasi Navare
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.What about downclock modes?!
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
fwiw I've got two laptops with eDP's having more than ten modes.
those ten are probably a list of modes with scaler right?!
Yeah, Clint very graciously explained that to me after I sent the email.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Dhinakaran
Quoted 10 lines · Manasi Navare
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
Quoted 8 lines
Quoted 5 lines
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
fwiw I've got two laptops with eDP's having more than ten modes.
Yes but link training is not supposed to fail for eDP since its a fixed connection and so after discussing with Daniel and Jani, this is the consensus that we shouldnt be falling back and retraining in case of eDP since most eDP panels are going to have 1 or 2 modes.
Manasi
Quoted 95 lines
Quoted 95 lines
Quoted 5 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.Regards
ManasiQuoted 80 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Manasi Navare
Quoted 11 lines · Dhinakaran
Quoted 10 lines · Manasi Navare
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
fwiw I've got two laptops with eDP's having more than ten modes.
Hmm, I have always dealt with laptops with eDPs with a fixed mode and so are the systems in CI which are giving this "no mode left on the connector error".
Manasi
Quoted 103 lines
Yes but link training is not supposed to fail for eDP since its a fixed connection and so after discussing with Daniel and Jani, this is the consensus that we shouldnt be falling back and retraining in case of eDP since most eDP panels are going to have 1 or 2 modes.
Manasi
Quoted 95 lines
Quoted 95 lines
Quoted 5 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.Regards
ManasiQuoted 80 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Manasi Navare
Quoted 8 lines · Rodrigo Vivi
On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare
<[1][email protected]> wrote:In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
What about downclock modes?!
What are the downclock modes? We have seen an issue with pruning modes in case of eDP panel where we end up pruning the mode due to link train fallback and then we get an error saying "No modes available for the connector"
Quoted 4 lines
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.
Quoted 7 lines
Quoted 1 line
Is there any bug associated with this patch?
Yes this is the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101518
But the reason I didnt have this in the Fixes tab is because this patch will not fix the bug, it will just isolate to it being a bug with AUX Timeouts warning.
We use References: for that. Fixes: is for when you fix a bug in a previous patch, and since this fixes a regression you need to add a Fixes:
line that references your original link training failure fallback. -Daniel
Quoted 88 lines
Regards
ManasiQuoted 70 lines
Cc: Jani Nikula <[2][email protected]> Cc: Jim Bride <[3][email protected]> Cc: Ville Syrjälä <[4][email protected]> Cc: Daniel Vetter <[5][email protected]> Signed-off-by: Manasi Navare <[6][email protected]> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4fd4853..edac0c8 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 }; * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp(struct intel_dp *intel_dp) +bool is_edp(struct intel_dp *intel_dp) { struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 05907fa..18ec61f 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->[7]base.base.id, intel_connector->[8]base.name, intel_dp->link_rate, intel_dp->lane_count); - if (!intel_dp_get_link_train_fallback_values(intel_dp, + /* Dont fallback and prune modes if its eDP */ + if (!is_edp(intel_dp) && !intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count)) /* Schedule a Hotplug Uevent to userspace to start modeset */ diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index fa47285..9800a15 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) } bool intel_dp_read_dpcd(struct intel_dp *intel_dp); +bool is_edp(struct intel_dp *intel_dp); int intel_dp_link_required(int pixel_clock, int bpp); int intel_dp_max_data_rate(int max_link_clock, int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv, -- 2.1.4 _______________________________________________ Intel-gfx mailing list [9][email protected] [10]https://lists.freedesktop.org/mailman/listinfo/intel-gfxReferences
Quoted 10 lines
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
7. http://base.base.id/
8. http://base.name/
9. mailto:[email protected]
10. https://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Do not do link training fallback or prune modes for eDP
In reply to Manasi Navare== Series Details ==
== Series Details ==
Series: drm/i915: Do not do link training fallback or prune modes for eDP
URL : https://patchwork.freedesktop.org/series/28900/
State : success
== Summary ==
Series 28900v1 drm/i915: Do not do link training fallback or prune modes for eDP
https://patchwork.freedesktop.org/api/1.0/series/28900/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:453s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:443s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:359s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:550s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:520s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:523s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:507s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:609s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:445s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:422s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:423s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:506s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:477s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:480s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:597s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:596s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:530s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:482s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:486s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:440s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:503s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:553s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:409s
ada53b43f81fe618f3f0f1dfbd3dd776bb277323 drm-tip: 2017y-08m-16d-15h-18m-56s UTC integration manifest 8f6b3cf6104d drm/i915: Do not do link training fallback or prune modes for eDP
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5422/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 22 lines · Manasi Navare
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.Cc Jani Nikula <[email protected]>Cc Jim Bride <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0
drivers/gpu/drm/i915/intel_dp.c static const int default_rates[] = { 162000, 270000, 540000 }; · line 112
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 };* If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp (struct intel_dp *intel_dp) +bool is_edp (struct intel_dp *intel_dp)
Make that intel_dp_is_edp when you expose it outside of intel_dp.c
BR,
Jani
Quoted 29 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0{struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->base.base.id, intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); -if (!intel_dp_get_link_train_fallback_values (intel_dp, +/* Dont fallback and prune modes if its eDP */ +if (!is_edp (intel_dp) && !intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))/* Schedule a Hotplug Uevent to userspace to start modeset */ drivers/gpu/drm/i915/intel_drv.h +1
-0@@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) }bool intel_dp_read_dpcd (struct intel_dp *intel_dp); +bool is_edp (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv,
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 31 lines · Jani Nikula
Quoted 22 lines · Manasi Navare
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.Cc Jani Nikula <[email protected]>Cc Jim Bride <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0drivers/gpu/drm/i915/intel_dp.c static const int default_rates[] = { 162000, 270000, 540000 }; · line 112
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 };* If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp (struct intel_dp *intel_dp) +bool is_edp (struct intel_dp *intel_dp)Make that
intel_dp_is_edpwhen you expose it outside ofintel_dp.c
Quoted 3 lines
BR,
Jani
Yea renaming it as intel_dp_is_edp() makes sense after making it a non static function. So should I make a seperate patch for this change and changing the name at all places that call is_edp() currently?
Regards
Manasi
Quoted 24 lines
Quoted 24 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0{struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->base.base.id, intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); -if (!intel_dp_get_link_train_fallback_values (intel_dp, +/* Dont fallback and prune modes if its eDP */ +if (!is_edp (intel_dp) && !intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))/* Schedule a Hotplug Uevent to userspace to start modeset */ drivers/gpu/drm/i915/intel_drv.h +0
-0@@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) }
Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/i915/intel_drv.h +1
-0bool intel_dp_read_dpcd (struct intel_dp *intel_dp); +bool is_edp (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv,Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 36 lines · Manasi Navare
Quoted 31 lines · Jani Nikula
Quoted 22 lines · Manasi Navare
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.Cc Jani Nikula <[email protected]>Cc Jim Bride <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0drivers/gpu/drm/i915/intel_dp.c static const int default_rates[] = { 162000, 270000, 540000 }; · line 112
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 };* If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp (struct intel_dp *intel_dp) +bool is_edp (struct intel_dp *intel_dp)Make that
intel_dp_is_edpwhen you expose it outside ofintel_dp.cQuoted 3 lines
BR,
Jani
Quoted 7 lines
Yea renaming it as
intel_dp_is_edp()makes sense after making it a non static function. So should I make a seperate patch for this change and changing the name at all places that callis_edp()currently?Regards
Manasi
Don't we already have a intel_dp_is_edp() that checks VBT? That'll need to be renamed if is_edp() is going to become intel_dp_is_edp()
Btw I remember seeing Jim's psr patch making this function global(non-static?) too.
Quoted 32 lines
Quoted 24 lines
Quoted 24 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0{struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->base.base.id, intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); -if (!intel_dp_get_link_train_fallback_values (intel_dp, +/* Dont fallback and prune modes if its eDP */ +if (!is_edp (intel_dp) && !intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))/* Schedule a Hotplug Uevent to userspace to start modeset */ drivers/gpu/drm/i915/intel_drv.h +0
-0@@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) }Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/i915/intel_drv.h +1
-0bool intel_dp_read_dpcd (struct intel_dp *intel_dp); +bool is_edp (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv,Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 41 lines · Dhinakaran
Quoted 40 lines · Manasi Navare
Quoted 31 lines · Jani Nikula
Quoted 22 lines · Manasi Navare
In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector.
Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP.Cc Jani Nikula <[email protected]>Cc Jim Bride <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dp_link_training.c | 3 ++- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +0
-0drivers/gpu/drm/i915/intel_dp.c static const int default_rates[] = { 162000, 270000, 540000 }; · line 112
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -109,7 +109,7 @@ static const int default_rates[] = { 162000, 270000, 540000 };* If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. */ -static bool is_edp (struct intel_dp *intel_dp) +bool is_edp (struct intel_dp *intel_dp)Make that
intel_dp_is_edpwhen you expose it outside ofintel_dp.cQuoted 3 lines
BR,
JaniYea renaming it as
intel_dp_is_edp()makes sense after making it a non static function. So should I make a seperate patch for this change and changing the name at all places that callis_edp()currently?
Quoted 7 lines
Quoted 3 lines
Regards
ManasiDon't we already have a
intel_dp_is_edp()that checks VBT? That'll need to be renamed ifis_edp()is going to becomeintel_dp_is_edp()
Yes just noticed we do have that intel_dp_is_edp(). But I agree that we need to add intel_dp prefix if we are going to expose the is_edp() function.
Do you have any suggestions for the name?
Quoted 3 lines
Btw I remember seeing Jim's psr patch making this function global(non-static?) too.
Yes I have looked at it and that patch is still in review, so this review comment applies to his patch as well. So either he makes this change in his or it happens here. I plan to add this comment to Jim's PSR patch review too.
Regards
Manasi
Quoted 33 lines
Quoted 33 lines
Quoted 33 lines
Quoted 30 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0{struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -332,7 +332,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) intel_connector->base.base.id, intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); -if (!intel_dp_get_link_train_fallback_values (intel_dp, +/* Dont fallback and prune modes if its eDP */ +if (!is_edp (intel_dp) && !intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))/* Schedule a Hotplug Uevent to userspace to start modeset */ drivers/gpu/drm/i915/intel_drv.h +1
-0@@ -1548,6 +1548,7 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) }bool intel_dp_read_dpcd (struct intel_dp *intel_dp); +bool is_edp (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes); bool intel_digital_port_connected(struct drm_i915_private *dev_priv,Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx