Skip to contentSkip to conversation

Patch "irqchip/atmel-aic: Fix unbalanced refcount in aic_common_rtc_irq_fixup()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 20, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

irqchip/atmel-aic: Fix unbalanced refcount in aic_common_rtc_irq_fixup()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
irqchip-atmel-aic-fix-unbalanced-refcount-in-aic_common_rtc_irq_fixup.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 277867ade8262583f4280cadbe90e0031a3706a7 Mon Sep 17 00:00:00 2001

From: Boris Brezillon <[email protected]>
Date: Tue, 4 Jul 2017 11:10:40 +0200
Subject: irqchip/atmel-aic: Fix unbalanced refcount in aic_common_rtc_irq_fixup()

From: Boris Brezillon <[email protected]>

commit 277867ade8262583f4280cadbe90e0031a3706a7 upstream.

of_find_compatible_node() is calling of_node_put() on its first argument thus leading to an unbalanced of_node_get/put() issue if the node has not been retained before that.

Instead of passing the root node, pass NULL, which does exactly the same:
iterate over all DT nodes, starting from the root node.

Fixes 3d61467f9bab ("irqchip: atmel-aic: Implement RTC irq fixup")
---
 drivers/irqchip/irq-atmel-aic-common.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-atmel-aic-common.c +2 -2
@@ -148,9 +148,9 @@ void __init aic_common_rtc_irq_fixup(str
 	struct device_node *np;
 	void __iomem *regs;
 
-	np = of_find_compatible_node(root, NULL, "atmel,at91rm9200-rtc");
+	np = of_find_compatible_node(NULL, NULL, "atmel,at91rm9200-rtc");
 	if (!np)
-		np = of_find_compatible_node(root, NULL,
+		np = of_find_compatible_node(NULL, NULL,
 					     "atmel,at91sam9x5-rtc");
 
 	if (!np)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/irqchip-atmel-aic-fix-unbalanced-of_node_put-in-aic_common_irq_fixup.patch queue-4.4/irqchip-atmel-aic-fix-unbalanced-refcount-in-aic_common_rtc_irq_fixup.patch