Skip to contentSkip to conversation

openconnect: fix parallel compilation failure

PATCH In review [email protected] 2 participants 3 messages Aug 23, 2017 – Aug 24, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openconnect: fix parallel compilation failure

From: Chen Qi <[email protected]>

This patch solves the following error which appears now and then because of parallel building.

../git/main.c:78:21: fatal error: version.c: No such file or directory

version.c is generated at build time. And it's needed by some objects. So it needs to be generated first to avoid compilation failure.

This patch fix the problem by generating version.c first before building others.

---
 meta-networking/recipes-connectivity/openconnect/openconnect_git.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-networking/recipes-connectivity/openconnect/openconnect_git.bb +4 -0
index 3a1f0f3..4242aa5 100644
@@ -25,3 +25,7 @@ inherit autotools pkgconfig
 
 EXTRA_OECONF += "--with-vpnc-script=${SYSROOT_DESTDIR}${sysconfdir}/vpnc/vpnc-script \
                  --disable-static"
+
+do_compile_prepend() {
+    make version.c
+}
Signature · 1 line
1.9.1
#1 lore raw
Quoted 27 lines · On 23 August 2017 at 13:08, <[email protected]> wrote:

From: Chen Qi <[email protected]>

This patch solves the following error which appears now and then because of parallel building.

../git/main.c:78:21: fatal error: version.c: No such file or directory

version.c is generated at build time. And it's needed by some objects. So it needs to be generated first to avoid compilation failure.

This patch fix the problem by generating version.c first before building others.

---
 meta-networking/recipes-connectivity/openconnect/openconnect_git.bb | 4
++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

onnect_git.bb b/meta-networking/recipes-connectivity/openconnect/openc onnect_git.bb
index 3a1f0f3..4242aa5 100644

meta-networking/recipes-connectivity/openconnect/openconnect_git.bb inherit autotools pkgconfig · line 31

Quoted 8 lines
meta-networking/recipes-connectivity/openconnect/openconnect_git.bb +4 -0
@@ -25,3 +25,7 @@ inherit autotools pkgconfig
 
 EXTRA_OECONF += "--with-vpnc-script=${SYSROOT_DESTDIR}${sysconfdir}/vpnc/vpnc-script
 \
                  --disable-static"
+
+do_compile_prepend() {
+    make version.c
+}

Upstream has had a proper Makefile.am fix for this since August 2016. I think the recipe should just be upgraded -- VPN software from 2015 is a bad idea.

Jussi

author
#2 lore raw
Quoted 48 lines · Jussi Kukkonen

On 23 August 2017 at 13:08, <[email protected] <mailto:[email protected]>> wrote:

    From: Chen Qi <[email protected] <mailto:[email protected]>>

    This patch solves the following error which appears now and then
    because of
    parallel building.

      ../git/main.c:78:21: fatal error: version.c: No such file or
    directory

    version.c is generated at build time. And it's needed by some
    objects. So
    it needs to be generated first to avoid compilation failure.

    This patch fix the problem by generating version.c first before
    building others.

    Signed-off-by: Chen Qi <[email protected]
    <mailto:[email protected]>>
    ---
     meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
    <http://openconnect_git.bb> | 4 ++++
     1 file changed, 4 insertions(+)

    diff --git
    a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
    <http://openconnect_git.bb>
    b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
    <http://openconnect_git.bb>
    index 3a1f0f3..4242aa5 100644
    ---
    a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
    <http://openconnect_git.bb>
    +++
    b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb
    <http://openconnect_git.bb>
    @@ -25,3 +25,7 @@ inherit autotools pkgconfig

     EXTRA_OECONF +=
    "--with-vpnc-script=${SYSROOT_DESTDIR}${sysconfdir}/vpnc/vpnc-script \
                      --disable-static"
    +
    +do_compile_prepend() {
    +    make version.c
    +}
Quoted 3 lines

Upstream has had a proper Makefile.am fix for this since August 2016. I think the recipe should just be upgraded -- VPN software from 2015 is a bad idea.

Jussi

Thanks a lot. I'll send out a patch to upgrade it.

Best Regards,

Chen Qi