Patch "ACPI: device property: Fix node lookup in acpi_graph_get_child_prop_value()" has been added to the 4.12-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ACPI: device property: Fix node lookup in acpi_graph_get_child_prop_value()
to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-device-property-fix-node-lookup-in-acpi_graph_get_child_prop_value.patch
and it can be found in the queue-4.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
b5212f57da145e53df790a7e211d94daac768bf8Mon Sep 17 00:00:00 2001
From: Sakari Ailus <[email protected]>
Date: Tue, 22 Aug 2017 23:39:58 +0300
Subject: ACPI: device property: Fix node lookup in acpi_graph_get_child_prop_value()
From: Sakari Ailus <[email protected]>
commit b5212f57da145e53df790a7e211d94daac768bf8 upstream.
acpi_graph_get_child_prop_value() is intended to find a child node with a certain property value pair. The check
if (!fwnode_property_read_u32(fwnode, prop_name, &nr)) continue;
is faulty: fwnode_property_read_u32() returns zero on success, not on failure, leading to comparing values only if the searched property was not found.
Moreover, the check is made against the parent device node instead of the child one as it should be.
--- drivers/acpi/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/property.c +1 -1
@@ -1046,7 +1046,7 @@ static struct fwnode_handle *acpi_graph_fwnode_for_each_child_node (fwnode, child) {u32 nr; -if (!fwnode_property_read_u32 (fwnode, prop_name, &nr)) +if (fwnode_property_read_u32 (child, prop_name, &nr))continue ;if (val == nr)
Patches currently in stable-queue which might be from [email protected] are
queue-4.12/acpi-device-property-fix-node-lookup-in-acpi_graph_get_child_prop_value.patch