Skip to contentSkip to conversation

Patch "ntb: ntb_test: ensure the link is up before trying to configure the mws" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Aug 28, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ntb: ntb_test: ensure the link is up before trying to configure the mws

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ntb-ntb_test-ensure-the-link-is-up-before-trying-to-configure-the-mws.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 0eb46345364d7318b11068c46e8a68d5dc10f65e Mon Sep 17 00:00:00 2001

From: Logan Gunthorpe <[email protected]>
Date: Tue, 25 Jul 2017 14:57:42 -0600
Subject: ntb: ntb_test: ensure the link is up before trying to configure the mws

From: Logan Gunthorpe <[email protected]>

commit 0eb46345364d7318b11068c46e8a68d5dc10f65e upstream.

After the link tests, there is a race on one side of the test for the link coming up. It's possible, in some cases, for the test script to write to the 'peer_trans' files before the link has come up.

To fix this, we simply use the link event file to ensure both sides see the link as up before continuning.

Fixes a9c59ef77458 ("ntb_test: Add a selftest script for the NTB subsystem")
---
 tools/testing/selftests/ntb/ntb_test.sh |    4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/ntb/ntb_test.sh +4 -0
@@ -326,6 +326,10 @@ function ntb_tool_tests()
 	link_test $LOCAL_TOOL $REMOTE_TOOL
 	link_test $REMOTE_TOOL $LOCAL_TOOL
 
+	#Ensure the link is up on both sides before continuing
+	write_file Y $LOCAL_TOOL/link_event
+	write_file Y $REMOTE_TOOL/link_event
+
 	for PEER_TRANS in $(ls $LOCAL_TOOL/peer_trans*); do
 		PT=$(basename $PEER_TRANS)
 		write_file $MW_SIZE $LOCAL_TOOL/$PT

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/ntb-ntb_test-ensure-the-link-is-up-before-trying-to-configure-the-mws.patch